Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Composer 2 support #51

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

alxy
Copy link

@alxy alxy commented Dec 30, 2020

Initial attempt to fix #50

  • Use composer create-project october/october to install october. This is the new preferred way to install October from version 1.1.0 on. It also requires less hacks, e.g. to load the .htaccess file and works with Composer 2.
  • Bump the installed October version to 1.1.* (Maybe this can be automated or configurable?)
  • Install additional composer dependecies after plugins have been installed. Reason: If a plugin is installed via git remote and does have composer dependencies, those are only installed if we run composer install after the installation.
  • Bump to a new major version 1.0.0. Probably it is a good idea to have a separate branch for this version?

@tobias-kuendig
Copy link
Member

I'll wait with this PR for two reasons:

@alxy
Copy link
Author

alxy commented Jan 4, 2021

Fair points, just wanted to point out that the current develop branch of october does indeed work with Composer 2 as a custom fork of the merge-plugin is used that is compatible with version 2: https://github.com/octobercms/october/blob/develop/composer.json#L46

@yersey
Copy link

yersey commented Feb 4, 2021

@alxy What about .htaccess. What if it doesn't exist.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Composer 2 support
3 participants