-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Composer 2.0 compatibility #5033
Comments
It has been happening everywhere for a few days now, happens to everyone in our team. TEMPORARY solution:
|
@SaifurRahmanMohsin The issue is we use the |
@bennothommo using the L6 branch in @SaifurRahmanMohsin's case isn't the problem, he needs to update his composer.json to pull in 1.4.1 of the merge plugin instead of using dev-master. It's unfortunate that we were using dev-master in the first place, every project that's ever been pulled down before the recent fix will still have the broken version in their composer.json. |
Downgrade to 1.9.2 works for me, but in different project. |
This issue will be closed and archived in 3 days, as there has been no activity in the last 60 days. |
Marking this as In Progress as Wikimedia are working on it, and just so this doesn't get archived again. |
Hello, I tested it on the branch |
I made an adjustment for them that corrects this problem, let's see if they approve, I tested here with my fork and october, and ran the tests well on a large project with more than 40 plugins and with october developer branch and everything went well. |
@prhost please test wikimedia/composer-merge-plugin#189 (comment) against October, that's the PR that adds full 2.0 support to the merge plugin. |
I tested it here, my project ran fine with laravel 6. but I ran phpunit and presented the error below:
|
@LukeTowers fixed: fffa6db |
Thanks @bennothommo, it worked. However @LukeTowers I believe that this version of the composer-merge-plugin did not work for us, what we really should do is to merge the vendor autoload of a plugin with the main autoload did not work. I tested it by installing October.Drivers and creating an instance of Aws, one of the packages installed by him. |
@prhost how did you install the package? |
Within this plugin is the vendor folder I remember that there was a native october class that did this job, I don't know why @daftspunk left the previous class to use |
@prhost that native class still exists, it handles marketplace plugins, which if you run |
This comment has been minimized.
This comment has been minimized.
@anilloutombam We are aware of the error message - you do not need to re-paste the same error message, nor create another issue with the exact same message. |
What is the solution for now @bennothommo |
@anilloutombam Download Composer 1.10.17 locally into your October CMS folder and run that directly. |
If you happen to run into this problem when your build pipeline throws errors with composer v2, while it worked on v1. This might work:
This workaround makes sure that your pipeline runs Composer v1.x instead of v2 Suggestion found in the release notes: |
Worth noting that if you manually add the repository from here: wikimedia/composer-merge-plugin#189 (comment) and switch to the 2.0 patch branch in your project's composer.json it seems to work fine with 2.0. Using it on all my projects right now. |
@prhost I meet this problem too, do you have any workaround for this? |
@LukeTowers looks like the plugins' composer.json not loaded in the main project vendor folder in v1.1.1, how can I get this wokr? |
@everyx what makes you think that's the case? Did you remove any vendor directory from the plugin folder itself and run composer update from the project root? |
@LukeTowers thanks your reply, and I have solved this problem by # disable scripts
composer create-project --no-scripts october/october . 1.1.1;
# and run discover manually
php artisan package:discover; |
wikimedia/composer-merge-plugin#189 has been merged |
It seems like composer 2.0 is right around the corner. Downloading
https://getcomposer.org/composer.phar
already gives you a 2.0 build.Our deployments just started to fail because of this. It seems like there is an issue with the composer-merge-plugin, as it explicitly requires composer 1.1:
https://github.com/wikimedia/composer-merge-plugin/blob/master/composer.json#L15
I have opened an issue on the plugins' GitHub page:
wikimedia/composer-merge-plugin#184
I guess this needs a bump of the
wikimedia/composer-merge-plugin
dependency in October once a new version has been released.The text was updated successfully, but these errors were encountered: