Improve detection of 32 bit versions of ModelSim. #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rahulrs
suggested changes
Nov 3, 2017
There was a problem hiding this comment.
We are basing the judgement of using 64-bit on the Version preamble. Can we use "vsim -help" instead to make that judgement?
I ran:
$ vsim -help | grep 64
-64 Run in 64-bit mode
This doesn't grep in the Modelsim Altera version.
UPDATE: We could use the simpler method for now.
rahulrs
approved these changes
Nov 3, 2017
abelardojarab
pushed a commit
that referenced
this pull request
Nov 9, 2017
abelardojarab
pushed a commit
that referenced
this pull request
Nov 13, 2017
anandaravuri
added a commit
that referenced
this pull request
Nov 30, 2023
…ndary check fix#1 For the correct value of loop count, the following condition must be satisfied. max(READ,WRITE) * loop_count <= 268,435,456 fix #2 cannot have READs only (without any previous WRITEs) fix #3 READs cannot exceed #WRITEs Fix #4 Read HDM size from CSR. Signed-off-by: anandaravuri <ananda.ravuri@intel.com>
anandaravuri
added a commit
that referenced
this pull request
Dec 1, 2023
…u… (#3054) * ix:CXL traffic generator read/write bandwidth and input arguments boundary check fix#1 For the correct value of loop count, the following condition must be satisfied. max(READ,WRITE) * loop_count <= 268,435,456 fix #2 cannot have READs only (without any previous WRITEs) fix #3 READs cannot exceed #WRITEs Fix #4 Read HDM size from CSR. Signed-off-by: anandaravuri <ananda.ravuri@intel.com> * fix code review comments Signed-off-by: anandaravuri <ananda.ravuri@intel.com> --------- Signed-off-by: anandaravuri <ananda.ravuri@intel.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.