Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(cherry-pick) Fix: address issues pointed out by Python scanners (#3036) #3045

Merged
merged 1 commit into from
Nov 17, 2023

Commits on Nov 17, 2023

  1. Fix: address issues pointed out by Python scanners (#3036)

    ### Description
    Our Python scanners point out issues regarding the use of
    the subprocess module. The issues tend to be in 2 main
    categories:
    1) The use of subprocess.Popen() directly is discouraged.
    Instead, the scanners recommend using run, call, or checked_call.
    
    2) The use of any of the subprocess calls with shell=True 
    is forbidden, because it is prone to code injection attacks.
    Instead, the scanners require shell=False or omitting shell
    altogether.
    
    ### Collateral (docs, reports, design examples, case IDs):
    Python scans when preparing the release.
    
    
    - [ ] Document Update Required? (Specify FIM/AFU/Scripts)
    
    ### Tests added:
    
    
    ### Tests run:
    CI and manual testing of rtl_src_config.
    
    Signed-off-by: Tim Whisonant <tim.whisonant@intel.com>
    tswhison committed Nov 17, 2023
    Configuration menu
    Copy the full SHA
    6caeb00 View commit details
    Browse the repository at this point in the history