Fix: address issues pointed out by Python scanners #3036
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replacing it with pacsign-tests.sh. test.py contained several bandit violations concerning the use of os.system() and assert. Signed-off-by: Tim Whisonant <tim.whisonant@intel.com>
Replace with subprocess.run(cmd, check=True) to appease python scans. Signed-off-by: Tim Whisonant <tim.whisonant@intel.com>
Python scanners require that we avoid subprocess.Popen() and any subprocess call which has shell=True. Use subprocess.run(..., check=True) instead. Signed-off-by: Tim Whisonant <tim.whisonant@intel.com>
Python scan tools forbid subprocess.Popen() and any subprocess call which uses shell=True. Signed-off-by: Tim Whisonant <tim.whisonant@intel.com>
anandaravuri
previously approved these changes
Nov 7, 2023
tswhison
dismissed stale reviews from anandaravuri and michael-adler
via
170892b
anandaravuri
approved these changes
Nov 8, 2023
tswhison
added a commit
that referenced
this pull request
Nov 17, 2023
### Description Our Python scanners point out issues regarding the use of the subprocess module. The issues tend to be in 2 main categories: 1) The use of subprocess.Popen() directly is discouraged. Instead, the scanners recommend using run, call, or checked_call. 2) The use of any of the subprocess calls with shell=True is forbidden, because it is prone to code injection attacks. Instead, the scanners require shell=False or omitting shell altogether. ### Collateral (docs, reports, design examples, case IDs): Python scans when preparing the release. - [ ] Document Update Required? (Specify FIM/AFU/Scripts) ### Tests added: ### Tests run: CI and manual testing of rtl_src_config. Signed-off-by: Tim Whisonant <tim.whisonant@intel.com>
tswhison
added a commit
that referenced
this pull request
Nov 17, 2023
### Description Our Python scanners point out issues regarding the use of the subprocess module. The issues tend to be in 2 main categories: 1) The use of subprocess.Popen() directly is discouraged. Instead, the scanners recommend using run, call, or checked_call. 2) The use of any of the subprocess calls with shell=True is forbidden, because it is prone to code injection attacks. Instead, the scanners require shell=False or omitting shell altogether. ### Collateral (docs, reports, design examples, case IDs): Python scans when preparing the release. - [ ] Document Update Required? (Specify FIM/AFU/Scripts) ### Tests added: ### Tests run: CI and manual testing of rtl_src_config. Signed-off-by: Tim Whisonant <tim.whisonant@intel.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Our Python scanners point out issues regarding the use of
the subprocess module. The issues tend to be in 2 main
categories:
The use of subprocess.Popen() directly is discouraged.
Instead, the scanners recommend using run, call, or checked_call.
The use of any of the subprocess calls with shell=True
is forbidden, because it is prone to code injection attacks.
Instead, the scanners require shell=False or omitting shell
altogether.
Collateral (docs, reports, design examples, case IDs):
Python scans when preparing the release.
Tests added:
Tests run: