hssi: increate timeout to 1 second #3132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michael-adler
force-pushed
the
mcadler/hssi_timeout
branch
from
97dbda8
to
9bbaf0c
Compare
Pull Request Test Coverage Report for Build 9547837650Details
💛 - Coveralls |
Pull Request Test Coverage Report for Build 9547883543Details
💛 - Coveralls |
fpgamatt
reviewed
Jun 17, 2024
binaries/hssi/ethernet/hssicommon.py
Outdated
| # Mailbox register poll timeout 1 second. Responses are typically much | ||
| # faster than one second, but in rare cases can take a while. No reason | ||
| # to make this short since timeout is generally a failure. | ||
| HSSI_POLL_TIMEOUT = 1 |
There was a problem hiding this comment.
In the Linux Kernel the units of the timeout are usually given in the macro name
HSSI_POLL_TIMEOUT_MS or HSSI_POLL_TIMEOUT_SEC would be clearer.
michael-adler
force-pushed
the
mcadler/hssi_timeout
branch
from
9bbaf0c
to
12eadf7
Compare
Pull Request Test Coverage Report for Build 9550060885Details
💛 - Coveralls |
Some operations are taking longer than the current timeout, such as putting an HSSI port in loopback. Timeout is a failure, so waiting a little long isn't a problem. Actual completion observed has been over 100ms, so chose 1 second. The current timeout logic could be improved but is not changed in this commit. Time passed is calculated as the sum of sleep times, which assumes MMIO reads are free and sleep is exactly the requested wait. Signed-off-by: Michael Adler <michael.adler@intel.com>
michael-adler
force-pushed
the
mcadler/hssi_timeout
branch
from
12eadf7
to
80a04d0
Compare
fpgamatt
approved these changes
Jun 17, 2024
Pull Request Test Coverage Report for Build 9550358699Details
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some operations are taking longer than the current timeout, such as putting an HSSI port in loopback. Timeout is a failure, so waiting a little long isn't a problem. Actual completion observed has been over 100ms, so chose 1 second.
The current timeout logic could be improved but is not changed in this commit. Time passed is calculated as the sum of sleep times, which assumes MMIO reads are free and sleep is exactly the requested wait.
Tests run:
Set loopback on 8x25 interfaces in iseries-dk, n6001