ASE: Solve inconsistency in pthreads for Socket_srv_tid #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Pthread_join for socket_srv is now called in start_sim_kill function to make sure the thread is destroyed .
|
DCP regression tests result is available at |
|
Looks good. You can do a reg_exe --farm --official-only to get a clean run. I'll approve. |
deepakcu84
approved these changes
Jan 12, 2018
anandaravuri
added a commit
that referenced
this pull request
Sep 18, 2020
ada8bd1 Merge pull request #85 from OPAE/aravuri/fix_subrepo 6c85e53 opae-libs: update cmaklist tag to release branch 38c747d Merge pull request #84 from OPAE/aravuri/fix_ver 7e40e35 opae-sdk: update opae release version to 2.0 2fa56e6 opae-cxx: fix coding style (#83) 60b2ade opae-cxx: fix issue found by checker (#82) c3c2710 Fix issues identified by checkers. (#81) 07b1a98 Improve malloc error handling in xfpga_fpgaOpen (#76) 8eb328a A static analysis check (#75) git-subtree-dir: opae-libs git-subtree-split: ada8bd1
r-rojo
pushed a commit
that referenced
this pull request
Oct 11, 2021
* remove unused variable
From clang static analysis
pvalue.h:98:15: warning: Although the value stored to 'u'
is used in the enclosing expression, the value is
never actually read from 'u'
if (0 != (u = uuid_parse(str, data_.data()))) {
^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
This can be simplified by removing the 'u' and
checking the status directly.
Signed-off-by: Tom Rix <trix@redhat.com>
* check return of read mmio
From clang static analysis
afu_metrics.c:160:4: warning: Value stored to 'result'
is never read [deadcode.DeadStores]
result = xfpga_fpgaReadMMIO64(handle, 0, ...
^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Check the status and return on error
Signed-off-by: Tom Rix <trix@redhat.com>
* check return and report error
From clang static analysis
metrics_utils.c:325:3: warning: Value stored to 'result'
is never read
result = xfpga_bmcGetSDRDetails(_handle, values, x, &details);
Check the status and return on error
Signed-off-by: Tom Rix <trix@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to make sure the thread is destroyed .