c++: Fix pvalue stream operator to call fpga get #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the stream operator is called on a pvalue struct or a guid_t struct, its copied value may not be an accurate reflection of the property stored in its `fpga_properties*` member variable `props_` This updates the `<<` operator to use the approprate getter function (`get_` for `pvalue` or `fpgaPropertiesGetGUID` for `guid_t`) to get the value from its `fpga_properties*` member, `props_`.
anandaravuri
added a commit
that referenced
this pull request
Sep 18, 2020
ada8bd1 Merge pull request #85 from OPAE/aravuri/fix_subrepo 6c85e53 opae-libs: update cmaklist tag to release branch 38c747d Merge pull request #84 from OPAE/aravuri/fix_ver 7e40e35 opae-sdk: update opae release version to 2.0 2fa56e6 opae-cxx: fix coding style (#83) 60b2ade opae-cxx: fix issue found by checker (#82) c3c2710 Fix issues identified by checkers. (#81) 07b1a98 Improve malloc error handling in xfpga_fpgaOpen (#76) 8eb328a A static analysis check (#75) git-subtree-dir: opae-libs git-subtree-split: ada8bd1
r-rojo
pushed a commit
that referenced
this pull request
Oct 11, 2021
The openclose open_06 test simulated malloc failures show that malloc failures in wsid_tracker_init need to be handled. So check the returns and cleanup on failures. Signed-off-by: Tom Rix <trix@redhat.com>
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the stream operator is called on a pvalue struct or a guid_t
struct, its copied value may not be an accurate reflection of the
property stored in its
fpga_properties*member variableprops_This updates the
<<operator to use the approprate getter function(
get_forpvalueorfpgaPropertiesGetGUIDforguid_t) to getthe value from its
fpga_properties*member,props_.