Extend execute_entity_task capabilities #1297
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TimoRoth
force-pushed
the
new_task_logic
branch
6 times, most recently
from
e5f6393
to
a85f256
Compare
TimoRoth
force-pushed
the
new_task_logic
branch
from
a85f256
to
8ee4020
Compare
|
Some performance comparisons: Old method: New method: So there is a small performance benefit for my cobbled together test case. And more importantly: Not a performance regression. |
|
Cheers! I'll try to think of this when updating the notebooks in future OGGM versions |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the ability to pass a list of tasks to execute_entity_task, which will then execute all tasks in that list in sequence on each gdir, potentially more efficiently distributing the work, avoiding CPU downtime.
Also documents some abilities the function had for a long time about per-gdir kwargs.