Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small dynamic spinup adaption #1514

Merged
merged 4 commits into from
Dec 14, 2022

Conversation

pat-schmitt
Copy link
Member

@pat-schmitt pat-schmitt commented Dec 14, 2022

I realized that after run_dynamic_mu_star_calibration the resulting model run is not always starting from the given start year. The reason for this is that the dynamic spinup tries out shorter spinup periods (= later start years) if the glacier is becoming ice-free or growing out of the boundary (e.g. the idea is if the spinup period is shorter the glacier has less time to grow out of the boundary). But for analysis, it would be nice to have a time series of all glaciers which start at the same defined year.

Therefore I introduce here a new option to deal with this in run_dynamic_spinup, which is the new default in run_dynamic_mu_star_calibration: If the period must be shortened we extend the time series with a shorter fixed-geometry-spinup.

  • Tests added/passed
  • Fully documented (in Tutorial)
  • Entry in whats-new.rst

Copy link
Member

@fmaussion fmaussion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@pat-schmitt pat-schmitt merged commit 12ef630 into OGGM:master Dec 14, 2022
@pat-schmitt pat-schmitt deleted the small_dynamic_spinup_adaption branch January 17, 2023 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants