Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor distrib funcs and add them to OGGM #1585

Merged
merged 6 commits into from May 21, 2023
Merged

Conversation

fmaussion
Copy link
Member

This moves @anoukvlug 's functions out of the notebook and adds them to the OGGM sandbox.

The algorithm did not change but it is now considerably faster (moved from xarray to numpy and use of np.digitize)

Excellent algorithm @anoukvlug , very clever

@fmaussion
Copy link
Member Author

animation.mp4

@fmaussion
Copy link
Member Author

TODOs: dealing with various output files (past + projections) and with RGI date (probably some small refactoring involved)

@fmaussion
Copy link
Member Author

OK so in the process I uncovered a bug in distribute_thickness_per_altitude -> the results changed slightly towards thicker ice thicknesses in the center and less thick at the border. The bug was that we were also estimating non-zero thickness outside of glaciers and as the result the smoothing would increase the thickness at the border.

@fmaussion fmaussion merged commit 01cba8b into OGGM:master May 21, 2023
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants