Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try to make the extract operation more robust #659

Merged
merged 1 commit into from
Jan 6, 2019

Conversation

fmaussion
Copy link
Member

This is to avoid random test fails like this one: https://travis-ci.org/OGGM/oggm/jobs/476007883

@TimoRoth
Copy link
Member

TimoRoth commented Jan 6, 2019 via email

@fmaussion
Copy link
Member Author

I'm not sure if deleting the target dir is such a good idea.

We delete dirs all the time in OGGM, since always. This part of the code is pretty robust and hidden anyway.

-> but I understand your concern and it might be worthwhile reviewing all the occurrences of dir delete in OGGM in a separate PR

@fmaussion fmaussion merged commit 9e3d000 into OGGM:master Jan 6, 2019
@fmaussion
Copy link
Member Author

In this case I'm not even sure why this is needed in the first place, the extractall operation really randomly failed with a fileexists error from time to time (also on cluster)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants