possible bug in get_ref_mb_glaciers_candidates #746
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! See pandas-dev/pandas#23398 So since recent pandas versions both are correct, but tolist is more compatible... |
|
I see. I checked (aka googled) for pandas to_list method, but got no results... However you prefer, I also don't mind ditching this and updating my pandas :-) |
|
let's avoid someone else's future problem then! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For me line 1874 in utils.
_downloads.py:cfg.DATA[key] = flink['RGI{}0_ID'.format(rgi_version)].to_list()does not work:
AttributeError: 'Series' object has no attribute 'to_list'I think it should be
tolist()But: How does this code pass the tests and also the crossvalidation on the cluster? Maybe I got something wrong here...