Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

possible bug in get_ref_mb_glaciers_candidates #746

Merged
merged 1 commit into from
Apr 18, 2019

Conversation

matthiasdusch
Copy link
Member

For me line 1874 in utils._downloads.py:
cfg.DATA[key] = flink['RGI{}0_ID'.format(rgi_version)].to_list()
does not work:
AttributeError: 'Series' object has no attribute 'to_list'

I think it should be tolist()

But: How does this code pass the tests and also the crossvalidation on the cluster? Maybe I got something wrong here...

@fmaussion
Copy link
Member

Thanks! See pandas-dev/pandas#23398

So since recent pandas versions both are correct, but tolist is more compatible...

@matthiasdusch
Copy link
Member Author

I see. I checked (aka googled) for pandas to_list method, but got no results...

However you prefer, I also don't mind ditching this and updating my pandas :-)

@fmaussion fmaussion merged commit 1e549f6 into OGGM:master Apr 18, 2019
@fmaussion
Copy link
Member

let's avoid someone else's future problem then!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants