ENH: to_list as alias for tolist #23398
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @ScientiaEtVeritas! Thanks for submitting the PR.
|
jreback
requested changes
Oct 28, 2018
Codecov Report
@@ Coverage Diff @@
## master #23398 +/- ##
==========================================
+ Coverage 92.21% 92.21% +<.01%
==========================================
Files 162 162
Lines 51761 51771 +10
==========================================
+ Hits 47731 47743 +12
+ Misses 4030 4028 -2
Continue to review full report at Codecov.
|
ScientiaEtVeritas
force-pushed
the
to_list-alias
branch
from
60363b0
to
7df4639
Compare
|
I've added a commit which reflects the points you mentioned. |
jreback
requested changes
Oct 30, 2018
jreback
reviewed
Oct 31, 2018
jreback
approved these changes
Nov 1, 2018
|
lgtm. @TomAugspurger @jorisvandenbossche if any comments. |
|
We use `.tolist()` in the docs in a few places. If we're recommend to_list
then we need to update those.
Personally, I don't care which we recommend. NumPy users will be familiar
with tolist. But if we're remvoing
tolist from the API docs, then we should update all the docs.
…On Wed, Oct 31, 2018 at 6:06 PM Jeff Reback ***@***.***> wrote:
lgtm. @TomAugspurger <https://github.com/TomAugspurger>
@jorisvandenbossche <https://github.com/jorisvandenbossche> if any
comments.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#23398 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABQHIuOCn_iZiOrp3dJCfM8T3lK0PmzJks5uqkkmgaJpZM4X99sH>
.
|
|
can you merge master and update the docs as indicated. |
jreback
requested changes
Dec 9, 2018
ScientiaEtVeritas
force-pushed
the
to_list-alias
branch
from
63a1122
to
5d58584
Compare
ScientiaEtVeritas
force-pushed
the
to_list-alias
branch
from
5d58584
to
b15bfe9
Compare
|
I merged master – and updated all places where |
jreback
requested changes
Dec 12, 2018
jreback
approved these changes
Dec 13, 2018
|
thanks @ScientiaEtVeritas |
Pingviinituutti
pushed a commit
to Pingviinituutti/pandas
that referenced
this pull request
Feb 28, 2019
Pingviinituutti
pushed a commit
to Pingviinituutti/pandas
that referenced
this pull request
Feb 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git diff upstream/master -u -- "*.py" | flake8 --diff