Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add flux gate to numerical model for mass-conservation tests #944

Merged
merged 5 commits into from
Feb 8, 2020

Conversation

fmaussion
Copy link
Member

Closes #857

  • Tests added/passed
  • Fully documented
  • Entry in whats-new.rst

cc @drounce

@fmaussion
Copy link
Member Author

One nice side effect of this tool: one can check mass-conservation of the dynamical model at the floating point precision.

Current checks are done for simple beds and for Hintereisferner, and mass-conservation is perfect (yay!). However, we slightly loose mass via the simple calving param (not much but still), but I decided not to care too much as we'll try another calving param soon.

@fmaussion
Copy link
Member Author

Correction: I discoverd a small bug in "calving", this is now also 100% mass-conservative

@fmaussion fmaussion merged commit 643a3b8 into OGGM:master Feb 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a flux gate to numerical model
1 participant