Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

init_glacier_directories to replace init_glacier_regions #983

Merged
merged 9 commits into from
Mar 25, 2020

Conversation

fmaussion
Copy link
Member

Closes #965

@pep8speaks
Copy link

pep8speaks commented Mar 24, 2020

Hello @fmaussion! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2020-03-25 12:11:50 UTC

@fmaussion fmaussion changed the title WIP: init_glacier_directories init_glacier_directories to replace init_glacier_regions Mar 25, 2020
@fmaussion
Copy link
Member Author

I'm going to merge this now - without review. hopefully I didn't brake anything. @matthiasdusch since you are always on the frontline any feedback is appreciated

@fmaussion
Copy link
Member Author

Just some more info:

  • init_glacier_regions is back to previous (and consistent) behavior before run_prepro_levels is broken #964
  • I tested it in the middle of this PR to be sure I didn't brake anything, but init_glacier_regions is now only minimally tested and not for full functionality (it would have meant duplicating all the tests). So in the future it might get broken without noticing (which is not a biggie since it's supposed to be deprectated)
  • so this shouldn't change anything for users in theory. Later we might start to send deprecation warnings (maybe in a couple of months)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

init_glacier_regions considered harmful
2 participants