Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tutorial explaining how to rebuild preprocessed directories #120

Merged
merged 6 commits into from
Apr 25, 2024

Conversation

pat-schmitt
Copy link
Member

Here I add an advanced tutorial that details how to rebuild the preprocessed glacier directories from the ground up. Related to OGGM/oggm#1675.

This tutorial not only guides users through each preprocessing level but also advises on how and where personal data can be integrated. Instead of delving into the specifics of each function, it provides links to related notebooks for further exploration.

An area previously unaddressed in our tutorials is the utilization of different climate datasets. I've included a section on this topic in the current tutorial. However, to maintain its concise and overview nature, this section might be better suited for a separate, dedicated tutorial—possibly within the OGGM shop, where there's already a placeholder for climate data discussions.

I welcome any reviews, especially regarding the appropriateness of the links to other tutorials and whether any relevant tutorials have been overlooked.

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@bearecinos
Copy link
Member

I have started reviewing the other PR but will get into this one too this week!

"source = None # we stick with the OGGM default\n",
"\n",
"# this tasks adds the DEM and defines the local grid\n",
"workflow.execute_entity_task(tasks.define_glacier_region, gdirs,\n",
Copy link
Member

@bearecinos bearecinos Mar 3, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pat-schmitt
this cell failed for me:

# define the border, we keep the default here
cfg.PARAMS['border'] = cfg.PARAMS['border']

# set the DEM source to use
source = None  # we stick with the OGGM default

# this tasks adds the DEM and defines the local grid
workflow.execute_entity_task(tasks.define_glacier_region, gdirs,
                             source=source);

image

It does work with SRTM as source though!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besides this cell! everything else works well also the explanation is very clear, as well as the tags to other tutorials for more information .... Great stuff @pat-schmitt ! 😄

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the review @bearecinos! Yes, good point. For some of the default DEMs you need to register. This is explained here https://oggm.org/tutorials/master/notebooks/tutorials/dem_sources.html#register-for-online-datasets. I will include this information in the notebook.

@pat-schmitt pat-schmitt merged commit 404fc71 into OGGM:master Apr 25, 2024
1 check passed
@pat-schmitt pat-schmitt deleted the add_prepro_tutorials branch April 25, 2024 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants