Main InstanceManager - unshare LODs as well #2000
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes a segfault which will appear if a mesh with shared vertices and existing edge data is used. It's triggered by the calls to "buildEdgeList()", since when doing this the LODs will be accessed. And since they haven't been altered, they will rely on the now deleted shared geometry, and their indices will be out of bounds, causing segfault.
|
thanks |
paroj
pushed a commit
that referenced
this pull request
May 3, 2021
This fixes a segfault which will appear if a mesh with shared vertices and existing edge data is used. It's triggered by the calls to "buildEdgeList()", since when doing this the LODs will be accessed. And since they haven't been altered, they will rely on the now deleted shared geometry, and their indices will be out of bounds, causing segfault.
raymond-w-ko
pushed a commit
to syandus/ogre
that referenced
this pull request
Jan 3, 2022
This fixes a segfault which will appear if a mesh with shared vertices and existing edge data is used. It's triggered by the calls to "buildEdgeList()", since when doing this the LODs will be accessed. And since they haven't been altered, they will rely on the now deleted shared geometry, and their indices will be out of bounds, causing segfault.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a segfault which will appear if a mesh with shared vertices and existing edge data is used.
It's triggered by the calls to "buildEdgeList()", since when doing this the LODs will be accessed.
And since they haven't been altered, they will rely on the now deleted shared geometry, and
their indices will be out of bounds, causing segfault.