Fix UBSan error about member call on address not pointing to ScriptTranslatorManager #2031
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…anslatorManager The error occurred when calling getTranslator(const AbstractNodePtr&) on an RTShader::SGScriptTranslatorManager in ScriptCompilerManager::getTranslator(const AbstractNodePtr&) due to the ScriptTranslatorManager not being exported. Therefore, technically, both OgreMain and OgreRTShaderSystem contain distinct ScriptTranslatorManager types. See https://stackoverflow.com/a/57304113 and https://bugs.llvm.org/show_bug.cgi?id=39191#c1.
paroj
pushed a commit
that referenced
this pull request
May 19, 2021
Fix UBSan error about member call on address not pointing to ScriptTranslatorManager The error occurred when calling getTranslator(const AbstractNodePtr&) on an RTShader::SGScriptTranslatorManager in ScriptCompilerManager::getTranslator(const AbstractNodePtr&) due to the ScriptTranslatorManager not being exported. Therefore, technically, both OgreMain and OgreRTShaderSystem contain distinct ScriptTranslatorManager types. See https://stackoverflow.com/a/57304113 and https://bugs.llvm.org/show_bug.cgi?id=39191#c1.
raymond-w-ko
pushed a commit
to syandus/ogre
that referenced
this pull request
Jan 3, 2022
Fix UBSan error about member call on address not pointing to ScriptTranslatorManager The error occurred when calling getTranslator(const AbstractNodePtr&) on an RTShader::SGScriptTranslatorManager in ScriptCompilerManager::getTranslator(const AbstractNodePtr&) due to the ScriptTranslatorManager not being exported. Therefore, technically, both OgreMain and OgreRTShaderSystem contain distinct ScriptTranslatorManager types. See https://stackoverflow.com/a/57304113 and https://bugs.llvm.org/show_bug.cgi?id=39191#c1.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The error occurred when calling getTranslator(const AbstractNodePtr&) on an RTShader::SGScriptTranslatorManager in ScriptCompilerManager::getTranslator(const AbstractNodePtr&) due to the ScriptTranslatorManager not being exported. Therefore, technically, both OgreMain and OgreRTShaderSystem contain distinct ScriptTranslatorManager types.
See https://stackoverflow.com/a/57304113 and https://bugs.llvm.org/show_bug.cgi?id=39191#c1.