Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renderbuffer reuse #429

Merged
merged 2 commits into from Jul 24, 2017
Merged

Renderbuffer reuse #429

merged 2 commits into from Jul 24, 2017

Conversation

paroj
Copy link
Member

@paroj paroj commented Jun 30, 2017

from: http://www.ogre3d.org/forums/viewtopic.php?f=25&t=92915

expected

each Ogre::Texture would have a unique resolve texture, but would share the same MSAA surface.

issue

  1. existing renderbuffers with the same format to not reused. Instead, a new renderbuffer is created with the same format, which overwrites the element in the map that might have been there prior to the call.
  2. Thus, when the original renderbuffer with the same format is supposed to be released, the new renderbuffer is found instead, and deleted.
  3. With the wrong renderbuffer deleted, the memory error occurs when a texture is deleted which refers to the incorrectly deleted renderbuffer.

@paroj paroj force-pushed the renderbuffer_reuse branch 3 times, most recently from 72b044f to a18b7cb Compare July 1, 2017 11:58
@paroj
Copy link
Member Author

paroj commented Jul 24, 2017

👍

@paroj paroj merged commit 7deb32b into OGRECave:master Jul 24, 2017
@paroj paroj deleted the renderbuffer_reuse branch July 24, 2017 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant