New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename get and create factories API to ohshown-event #46
Rename get and create factories API to ohshown-event #46
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow the sprint today is really productive!! Thanks for the effort and I am so excited about this very first step of #44.
I am +1 to this pull request, but I don't have a practical idea if we should land it now or later. Does FE want to follow up this change at the same time, or let's land anyway and let FE follow up later? @Neilxx @yanghaochang104 which approach you prefer?
|
Wooooow that's really greate! So let me wait for your PR for FE repo then? Thanks! Let's try to land both of them (PR of BE/FE) at the same time. |
@tai271828 FE PR created! |
OH-SHOWN/ohshown-frontend#63 landed, so let's move forward together. |
Deployed to the development site. Everything looks good. By "looks good" I meant manual checks pass including:
[1] initial loading
[2] communication between when uploading images
|
Why
What
How
{host}/server/api/factories
to{host}/server/api/ohshown-events
Test