Rename get and create factories api to ohshown #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tai271828
approved these changes
Mar 15, 2022
|
Deployed to the development site. Everything looks good OH-SHOWN/ohshown-backend#46 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Sync with Backend API endpoint path change OH-SHOWN/ohshown-backend#46 (comment)
What
Call API endpoint
/ohshow-eventsinstead of/factorieswhen get and create ohshown-eventsHow
Modify
index.tsfor the related GET and POST endpoint.Test
Test to hit new Backend API endpoints, looks good.
Not sure if we need more tests for this.