New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
small fixes and new rules #204
Conversation
update of version Introduction of maintenance code in extras
Codecov Report
@@ Coverage Diff @@
## master #204 +/- ##
=======================================
Coverage 76.07% 76.07%
=======================================
Files 7 7
Lines 1505 1505
=======================================
Hits 1145 1145
Misses 360 360 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. for new rules. Suggestion: Please mention rule name/summary in commit message.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine.
I will summarize the rules next time. All rules (including the new ones) are described in the rule overview.csv file. (now mentioned in great detail in the readme file). Let me know how the local tests went. @t-abdul-basser |
Let me know how the local tests went. @t-abdul-basser |
Oops. I meant to squash these commits before merging as per our policy. I will leave for now rather than reverting. |
fixes related to
#179
#149
and
#125
Changes try to to wrap up the OHDSI DQ Study and contribute the outputs of that effort to the community