Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

small fixes and new rules #204

Merged
merged 5 commits into from Jun 20, 2017
Merged

small fixes and new rules #204

merged 5 commits into from Jun 20, 2017

Conversation

vojtechhuser
Copy link
Contributor

fixes related to
#179
#149
and
#125

Changes try to to wrap up the OHDSI DQ Study and contribute the outputs of that effort to the community

measurement put, instead of observation
update of version

Introduction of maintenance code in extras
@codecov-io
Copy link

codecov-io commented Jun 15, 2017

Codecov Report

Merging #204 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #204   +/-   ##
=======================================
  Coverage   76.07%   76.07%           
=======================================
  Files           7        7           
  Lines        1505     1505           
=======================================
  Hits         1145     1145           
  Misses        360      360

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0307372...d5c225c. Read the comment docs.

Copy link
Contributor

@t-abdul-basser t-abdul-basser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. for new rules. Suggestion: Please mention rule name/summary in commit message.

Copy link
Contributor

@t-abdul-basser t-abdul-basser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine.

@vojtechhuser
Copy link
Contributor Author

vojtechhuser commented Jun 16, 2017

I will summarize the rules next time. All rules (including the new ones) are described in the rule overview.csv file. (now mentioned in great detail in the readme file). Let me know how the local tests went. @t-abdul-basser

@vojtechhuser
Copy link
Contributor Author

Let me know how the local tests went. @t-abdul-basser

@t-abdul-basser t-abdul-basser merged commit 8258bca into master Jun 20, 2017
@t-abdul-basser
Copy link
Contributor

Oops. I meant to squash these commits before merging as per our policy. I will leave for now rather than reverting.

@vojtechhuser vojtechhuser deleted the hbundle branch November 17, 2017 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants