Concept hierarchy addition #212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Performance enhancements for WebAPI/Atlas
|
Per #208, this is 2 of 2 features related to the V2.2.0 release of Atlas/WebAPI (OHDSI/WebAPI#217). Per guidance on PR #211, I'd recommend that this PR be reviewed only after #211 is reviewed and merged into master. |
|
We have done similar concept views. It is nice to make them into a table. I fully agree and support this. |
chrisknoll
added a commit
that referenced
this pull request
Oct 3, 2017
* Performance enhancements for WebAPI/Atlas (#212) * Update unit tests to explicitly skip creating the concept hierarchy to prevent Travis timeouts. * Removing dbDisconnect call * Move indices creation to separate script and function call. Addressing some roxygen warnings.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the creation of concept hierarchy tables to speed up the Datasources component in ATLAS.
The ATLAS and WebAPI changes will be done in another pull request.
See feature in WebAPI: link