Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add venn diagram #2794

Merged
merged 20 commits into from
Dec 12, 2022
Merged

Add venn diagram #2794

merged 20 commits into from
Dec 12, 2022

Conversation

anton-abushkevich
Copy link
Contributor

Resolves #2793

TitrS and others added 19 commits July 25, 2022 10:30
@TitrS
add export image and svg for charts
e595bee
@anton-abushkevich
export buttons restyle
5a127a2
@TitrS
added buttons to some charts
d0010c4
@TitrS
added filename when downloading images
f968d33
@TitrS
prepare venn diagram
0884b66
@TitrS
hid the legend and changed labels for the concept sets
d53d66e
@TitrS
changed height of venn diagram
a313201
@TitrS
change venn diagram after review
d99f1ef
@TitrS
updated the select of concept sets for click to the venn diagramm cir…
8b6f04b 
…cles
@TitrS
changed circles pathes, added the select area outside.
e850dcd
@TitrS
Merge branch 'export_button_with_options_to_all_visualizations' into …
afa1f30 
…add_venn_diagram
@TitrS
Merge branch 'master' into add_venn_diagram
50e87cf
@TitrS
added export buttons to venn chart and changed 'indentical' message
db0b621
@TitrS
Venn diagram | fixed compare huge and tiny concept sets
bd22556
@TitrS
Venn diagram | fixed display of circles
0ff1ae6
@TitrS
Venn diagram | added pattern stripe-fill
4938767
@TitrS
Venn diagram - changed labels of concept sets
f5afce8
@TitrS
Venn diagram - change calculating circles
7122444
@TitrS
Venn diagram - fixed error createPattern
deb834f
chrisknoll
chrisknoll requested changes Dec 9, 2022
View reviewed changes
Copy link
Collaborator

@chrisknoll chrisknoll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After clicking compare button, I get this error in console:

knockout-latest.js:63 Uncaught Error: Cannot find closing comment tag to match: ko if: compareResultsSame()

@chrisknoll chrisknoll merged commit 04c5009 into master Dec 12, 2022
@delete-merged-branch delete-merged-branch bot deleted the add_venn_diagram branch December 12, 2022 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrisknoll chrisknoll chrisknoll approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Venn diagram for clear concept set comparison
3 participants
@anton-abushkevich @chrisknoll @TitrS