Skip to content

Commit

Permalink
Merge pull request #448 from OHDSI/v5.4
Browse files Browse the repository at this point in the history
CDM V5.4
  • Loading branch information
clairblacketer committed Sep 22, 2021
2 parents 482b1f0 + 8d7d019 commit fd0703a
Show file tree
Hide file tree
Showing 249 changed files with 74,251 additions and 14,596 deletions.
Binary file removed .DS_Store
Binary file not shown.
5 changes: 5 additions & 0 deletions .Rbuildignore
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
^.*\.Rproj$
^\.Rproj\.user$
^LICENSE\.md$
.github/*
extras/*
129 changes: 129 additions & 0 deletions .github/workflows/R_CMD_check.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,129 @@
# For help debugging build failures open an issue on the RStudio community with the 'github-actions' tag.
# https://community.rstudio.com/new-topic?category=Package%20development&tags=github-actions
on:
push:
branches:
- '**'
pull_request:
branches:
- '**'

name: R-CMD-check

jobs:
R-CMD-check:
runs-on: ${{ matrix.config.os }}

name: ${{ matrix.config.os }} (${{ matrix.config.r }})

strategy:
# Test create and drop tables in a database so they cannot be executed in parallel
max-parallel: 1
fail-fast: false
matrix:
config:
- {os: macOS-latest, r: 'release'}
- {os: ubuntu-20.04, r: 'release', rspm: "https://packagemanager.rstudio.com/cran/__linux__/focal/latest"}
- {os: windows-latest, r: 'release'} # Does not appear to have Java 32-bit, hence the --no-multiarch

env:
R_REMOTES_NO_ERRORS_FROM_WARNINGS: true
RSPM: ${{ matrix.config.rspm }}
CDMDDLBASE_POSTGRESQL_USER: ${{ secrets.CDMDDLBASE_POSTGRESQL_USER }}
CDMDDLBASE_POSTGRESQL_PASSWORD: ${{ secrets.CDMDDLBASE_POSTGRESQL_PASSWORD }}
CDMDDLBASE_POSTGRESQL_SERVER: ${{ secrets.CDMDDLBASE_POSTGRESQL_SERVER }}
CDMDDLBASE_POSTGRESQL_SCHEMA: ${{ secrets.CDMDDLBASE_POSTGRESQL_SCHEMA }}
CDMDDLBASE_REDSHIFT_USER: ${{ secrets.CDMDDLBASE_REDSHIFT_USER }}
CDMDDLBASE_REDSHIFT_PASSWORD: ${{ secrets.CDMDDLBASE_REDSHIFT_PASSWORD }}
CDMDDLBASE_REDSHIFT_SERVER: ${{ secrets.CDMDDLBASE_REDSHIFT_SERVER }}
CDMDDLBASE_REDSHIFT_SCHEMA: ${{ secrets.CDMDDLBASE_REDSHIFT_SCHEMA }}
CDMDDLBASE_SQL_SERVER_USER: ${{ secrets.CDMDDLBASE_SQL_SERVER_USER }}
CDMDDLBASE_SQL_SERVER_PASSWORD: ${{ secrets.CDMDDLBASE_SQL_SERVER_PASSWORD }}
CDMDDLBASE_SQL_SERVER_SERVER: ${{ secrets.CDMDDLBASE_SQL_SERVER_SERVER }}
CDMDDLBASE_SQL_SERVER_CDM_SCHEMA: ${{ secrets.CDMDDLBASE_SQL_SERVER_CDM_SCHEMA }}
CDMDDLBASE_ORACLE_USER: ${{ secrets.CDMDDLBASE_ORACLE_USER }}
CDMDDLBASE_ORACLE_PASSWORD: ${{ secrets.CDMDDLBASE_ORACLE_PASSWORD }}
CDMDDLBASE_ORACLE_SERVER: ${{ secrets.CDMDDLBASE_ORACLE_SERVER }}
CDMDDLBASE_ORACLE_CDM_SCHEMA: ${{ secrets.CDMDDLBASE_ORACLE_CDM_SCHEMA }}

steps:
- uses: actions/checkout@v2

- uses: r-lib/actions/setup-r@v1
with:
r-version: ${{ matrix.config.r }}

- uses: r-lib/actions/setup-tinytex@v1

- uses: r-lib/actions/setup-pandoc@v1

- name: Query dependencies
run: |
install.packages('remotes')
saveRDS(remotes::dev_package_deps(dependencies = TRUE), ".github/depends.Rds", version = 2)
writeLines(sprintf("R-%i.%i", getRversion()$major, getRversion()$minor), ".github/R-version")
shell: Rscript {0}

- name: Cache R packages
if: runner.os != 'Windows'
uses: actions/cache@v2
with:
path: ${{ env.R_LIBS_USER }}
key: ${{ runner.os }}-${{ hashFiles('.github/R-version') }}-1-${{ hashFiles('.github/depends.Rds') }}
restore-keys: ${{ runner.os }}-${{ hashFiles('.github/R-version') }}-1-

- name: Install system dependencies
if: runner.os == 'Linux'
run: |
while read -r cmd
do
eval sudo $cmd
done < <(Rscript -e 'writeLines(remotes::system_requirements("ubuntu", "20.04"))')
- name: Install libssh
if: runner.os == 'Linux'
run: |
sudo apt-get install libssh-dev
- name: Install dependencies
run: |
remotes::install_deps(dependencies = TRUE, INSTALL_opts=c("--no-multiarch"))
remotes::install_cran("rcmdcheck")
shell: Rscript {0}

- name: Install covr
if: runner.os == 'macOS'
run: |
remotes::install_cran("covr")
shell: Rscript {0}

- name: Remove check folder if exists
if: runner.os == 'macOS'
run: unlink("check", recursive = TRUE)
shell: Rscript {0}

- name: Check
env:
_R_CHECK_CRAN_INCOMING_REMOTE_: false
run: rcmdcheck::rcmdcheck(args = c("--no-manual", "--as-cran", "--no-multiarch"), error_on = "warning", check_dir = "check")
shell: Rscript {0}

- name: Upload check results
if: failure()
uses: actions/upload-artifact@v2
with:
name: ${{ runner.os }}-r${{ matrix.config.r }}-results
path: check

- name: Upload source package
if: success() && runner.os == 'macOS' && github.event_name != 'pull_request' && github.ref == 'refs/heads/master'
uses: actions/upload-artifact@v2
with:
name: package_tarball
path: check/*.tar.gz

- name: Test coverage
if: runner.os == 'macOS'
run: covr::codecov()
shell: Rscript {0}

13 changes: 13 additions & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -2,3 +2,16 @@
.Rhistory
.RData
.Ruserdata
extras/CodeToRun.R

# OS generated files #
######################
.DS_Store
.DS_Store?
._*
.Spotlight-V100
.Trashes
ehthumbs.db
Thumbs.db
extras/codeToRun.R
output/
48 changes: 0 additions & 48 deletions BigQuery/OMOP CDM Results bigquery ddl.txt

This file was deleted.

Loading

3 comments on commit fd0703a

@kesadae11
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dear Colleagues!

I know that 6.0 is only in pre-release state and not fully supported, but I have some question after this merge.

Why the 6.0 version ddl codes has been removed from the master branch?
For example: https://github.com/OHDSI/CommonDataModel/blob/482b1f0388aada8f55d3f314c6514852658386ce/Sql%20Server/OMOP%20CDM%20sql%20server%20ddl.txt

It was an official release for v5.4 ?
In the future the only place where i can download 6.0 codes is that: https://github.com/OHDSI/CommonDataModel/releases/tag/v6.0.0?
Where will be tracing the development of 6.0 in the future?

Sorry to ask trivial things, I was very surprised by this big structural change in the repository.

BR

@clairblacketer
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @kesadae11 I am preparing the CDM v5.4 release and with it comes a major change to the repository as you noted. This is because we updated it to include an R package that creates the ddls, documentation, and even instantiates the tables in your environment. The ddls will be available in the repo in inst/ddl but we specifically left v6.0 out of that list as it has been causing confusion. Since it is a pre-release no tools and methods currently support it, which some collaborators find out the hard way by moving to v6 and finding out that ATLAS doesn't work as well for them. That being said, with the v5.4 release I am also planning a v6.0.1 bugfix release that updates the COST table as mentioned in #81 and adds back the COHORT table. You can still find the specification of v6.0 on the website and the csv files detailing the version are in the inst/csv folder. We may pick up the v6 series in the future of the OMOP CDM but for right now the suggestion is to stay with the v5 series if you can. We will also be releasing a v6.0 -> v5.4 script in the next few months if you are interested.

@kesadae11
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @clairblacketer!

Thank you for your clear answer!

Sorry, it will be my last question:
We already made our specification in v6.0 and we begun the ETL development in it, because the new location_history is very important for our data partner
If i understand well, if we want to use any functions of ATLAS in the near future we must use this v6.0 -> v5.4 converter? -or it just partially not working with 6.0?

Next time i will ask these on OMOP forum.

Thanks,
Adam

Please sign in to comment.