OMOP 5.3 - PostgreSQL MAJ (Visit Detail) #114
Conversation
|
I am working with Nicolas Paris on mimic ETL to OMOP and these are changes related to another call to have comments in the schema. These are very useful for folks that like to use those. @clairblacketer please review. |
|
Thanks @vojtechhuser and @parisni. I look it over this week. |
|
the conflicts might be the char(1) changes. |
|
OK. so we are watiting for January 2018 and v6 ,right In the meantime - does it mean we don't consider pull requests? I think we should change the readme to say tentative future version and have master be the experimentation place with new stuff. and point people to the release version of the repo. |
|
We can do pull requests no problem. Question is how. I cannot review Postgres stuff and char in there, I just don't know. We need somebody technical to review this. Can you ask? |
|
@vojtechhuser and @parisni I haven't forgotten about this PR. There is still some discussion around v5.3 and v6.0 so I want to make certain which version VISIT_DETAIL will be in before I pull this in. |
| @@ -8,7 +8,7 @@ Field|Required|Type|Description | |||
| |definition_type_concept_id|Yes|integer|Type defining what kind of Cohort Definition the record represents and how the syntax may be executed| | |||
| |cohort_definition_syntax|No|CLOB|Syntax or code to operationalize the Cohort definition| | |||
| |subject_concept_id|Yes|integer|A foreign key to the Concept to which defines the domain of subjects that are members of the cohort (e.g., Person, Provider, Visit).| | |||
| |cohort_instantiation_date|No|Date|A date to indicate when the Cohort was instantiated in the COHORT table| | |||
| |cohort_initiation_date|No|Date|A date to indicate when the Cohort was initiated in the COHORT table| | |||
There was a problem hiding this comment.
Good catch on this. All the DDLs say initiation date but the documentation says instantiation date
| @@ -14,7 +14,7 @@ Field|Required|Type|Description | |||
| |care_site_id|No|integer|A foreign key to the care site in the care site table that was visited.| | |||
| |visit_source_value|No|string(50)|The source code for the visit as it appears in the source data.| | |||
| |visit_source_concept_id|No|Integer|A foreign key to a Concept that refers to the code used in the source.| | |||
| |admitting_source_concept_id| |Integer |No |A foreign key to the predefined concept in the Place of Service Vocabulary reflecting the admitting source for a visit.| | |||
| |admitting_source_concept_id| Integer |No |A foreign key to the predefined concept in the Place of Service Vocabulary reflecting the admitting source for a visit.| | |||
There was a problem hiding this comment.
Thanks for fixing the errant pipe. The 'Integer' and 'No' just need to be switched so that the 'No' is in the column before 'Integer'
| @@ -0,0 +1,481 @@ | |||
| -- | |||
| --CLINICAL | |||
There was a problem hiding this comment.
These comments are great but can you also provide a code to retrieve them in the CodeExcerpts table?
Fixes #112
Fixes #106