Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create DDL to support the Oncology Extension Proposal. #23

Closed
mgurley opened this issue Jan 11, 2019 · 6 comments
Closed

Create DDL to support the Oncology Extension Proposal. #23

mgurley opened this issue Jan 11, 2019 · 6 comments
Assignees
Milestone

Comments

@mgurley
Copy link
Collaborator

mgurley commented Jan 11, 2019

No description provided.

@dimshitc
Copy link
Collaborator

Did we decide who's doing this?

@mgurley
Copy link
Collaborator Author

mgurley commented Jan 17, 2019

@dimshitc @rimusia @AEW0330
Yes, we decided that Rimma would first work on PostgreSQL and then hand off the results to Andrew/Robert to do Microsoft SQL Server. Task has been assigned to both.

@rimusia
Copy link
Collaborator

rimusia commented Jan 29, 2019

@rtmill
Copy link
Collaborator

rtmill commented Jan 29, 2019

SqlServerOncologyModuleDDL.txt

Notable differences from PostgreSQL version (above)

  • Changed all [int] fields to [bigint] per CDMv6
  • Created primary key for episode table
  • Removed duplicate constraint statement (fk episode.person_id -> person.person_id appears twice)

@rimusia
Copy link
Collaborator

rimusia commented Jan 29, 2019

Robert,

Thank you for fixing the pk and duplicate fk. I must have duplicated the fk entry in place of pk.

As for the change of IDs to BIGINT, I believe that the change applies only to the patient data tables (e.g. Person, Condition_Occurrence, etc.) but not to the vocabulary tables:

https://github.com/OHDSI/CommonDataModel/blob/master/PostgreSQL/OMOP%20CDM%20postgresql%20ddl.txt
and
https://github.com/OHDSI/CommonDataModel/wiki

The updated PostgreSQL file is attached.

PostgreSQL.Oncology.Module.DDL 2019-01-29.txt

Thanks.

@mgurley mgurley added this to the Active Sprint milestone Feb 26, 2019
@mgurley
Copy link
Collaborator Author

mgurley commented Jun 6, 2019

This is done. Any problems will be brought out in the beta testing.

@mgurley mgurley closed this as completed Jun 6, 2019
mgurley added a commit that referenced this issue Jun 6, 2019
mgurley added a commit that referenced this issue Jun 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants