Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BadRequestException: sample parameter size must fall in the range (1, 500) #1890

Closed
KSadomtsev opened this issue Jun 2, 2021 · 0 comments · Fixed by #1894 or OHDSI/Atlas#2554
Closed

BadRequestException: sample parameter size must fall in the range (1, 500) #1890

KSadomtsev opened this issue Jun 2, 2021 · 0 comments · Fixed by #1894 or OHDSI/Atlas#2554
Assignees
@ssuvorov-fls
Labels
bug
Milestone
V 2.9.1

Comments

@KSadomtsev
Copy link

webapi 2.9

Expected behavior

The sample is successful generated or some human-readable error

Actual behavior

image

2021-06-02 07:45:23.438 ERROR 36 --- [nio-8080-exec-5] o.o.w.u.GenericExceptionMapper : javax.ws.rs.BadRequestException: sample parameter size must fall in the range (1, 500) at org.ohdsi.webapi.cohortsample.dto.SampleParametersDTO.validate(SampleParametersDTO.java:39) at org.ohdsi.webapi.service.CohortSampleService.createCohortSample(CohortSampleService.java:131) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:498) at org.glassfish.jersey.server.model.internal.ResourceMethodInvocationHandlerFactory$1.invoke(ResourceMethodInvocationHandlerFactory.java:81)

Steps to reproduce behavior

1)Generate any cohort
2)Samples
3)Enter the number of patients greater than 500
@KSadomtsev KSadomtsev added the bug label Jun 2, 2021
@KSadomtsev KSadomtsev added this to TODO in Atlas 2.9 via automation Jun 2, 2021
@KSadomtsev KSadomtsev added this to the V 2.9.1 milestone Jun 2, 2021
@KSadomtsev KSadomtsev removed this from TODO in Atlas 2.9 Jun 2, 2021
ssuvorov-fls added a commit to OHDSI/Atlas that referenced this issue Jun 10, 2021
@ssuvorov-fls
error messasge is shown when number of patients is out of range(OHDSI…
c8f9aa8 
…/WebAPI#1890)
This was referenced Jun 10, 2021
Merged
Merged
ssuvorov-fls added a commit that referenced this issue Jun 11, 2021
@ssuvorov-fls
Some translations were changed(#1890)
b9c32da
anton-abushkevich pushed a commit that referenced this issue Jun 15, 2021
@ssuvorov-fls
BadRequest exception handling was added (#1894)
4c53959 
* BadRequest exception handling was added
Some translations were changed(#1892)

* Some translations were changed(#1890)

Co-authored-by: Sergey Suvorov <sergey.suvorov@odysseusinc.com>
anton-abushkevich pushed a commit to OHDSI/Atlas that referenced this issue Jun 15, 2021
@ssuvorov-fls
error messasge is shown when number of patients is out of range(OHDSI…
b5ee9ff 
…/WebAPI#1890) (#2554)

Co-authored-by: Sergey Suvorov <sergey.suvorov@odysseusinc.com>
ssuvorov-fls added a commit that referenced this issue Jun 15, 2021
@ssuvorov-fls
BadRequest exception handling was added (#1894)
f749698 
* BadRequest exception handling was added
Some translations were changed(#1892)

* Some translations were changed(#1890)

Co-authored-by: Sergey Suvorov <sergey.suvorov@odysseusinc.com>
(cherry picked from commit 4c53959)
ssuvorov-fls added a commit to OHDSI/Atlas that referenced this issue Jun 15, 2021
@ssuvorov-fls
error messasge is shown when number of patients is out of range(OHDSI…
904b0f9 
…/WebAPI#1890) (#2554)

Co-authored-by: Sergey Suvorov <sergey.suvorov@odysseusinc.com>
(cherry picked from commit b5ee9ff)
m0nhawk pushed a commit to uc-cdis/WebAPI that referenced this issue Nov 1, 2021
@ssuvorov-fls @m0nhawk
BadRequest exception handling was added (OHDSI#1894)
4f43626 
* BadRequest exception handling was added
Some translations were changed(OHDSI#1892)

* Some translations were changed(OHDSI#1890)

Co-authored-by: Sergey Suvorov <sergey.suvorov@odysseusinc.com>
m0nhawk pushed a commit to uc-cdis/Atlas that referenced this issue Nov 1, 2021
@ssuvorov-fls @m0nhawk
error messasge is shown when number of patients is out of range(OHDSI…
1e0dc79 
…/WebAPI#1890) (OHDSI#2554)

Co-authored-by: Sergey Suvorov <sergey.suvorov@odysseusinc.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ssuvorov-fls ssuvorov-fls

Labels
bug
Projects
None yet
Milestone
V 2.9.1
3 participants
@anton-abushkevich @ssuvorov-fls @KSadomtsev