Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ConceptNot ExistException should be validated (user-readable message) #1897

Closed
DKashenko opened this issue Jun 11, 2021 · 0 comments · Fixed by OHDSI/Atlas#2557 or #1898
Closed

ConceptNot ExistException should be validated (user-readable message) #1897

DKashenko opened this issue Jun 11, 2021 · 0 comments · Fixed by OHDSI/Atlas#2557 or #1898
Assignees
@ssuvorov-fls
Labels
bug
Milestone
v2.10.0

Comments

@DKashenko
Copy link

DKashenko commented Jun 11, 2021 •
edited by KSadomtsev

Expected behavior

Some warning message is shown. After making some validation in webApi, we should add some message on frontend side.

Actual behavior

Nothing happened. Error from the backend
WebAPI/estimation/54/generation/data_source
Request Method: POST
Status Code: 500
{"payload":{"cause":null,"stackTrace":[],"message":"An exception occurred: java.lang.reflect.UndeclaredThrowableException","localizedMessage":"An exception occurred: java.lang.reflect.UndeclaredThrowableException","suppressed":[]},"headers":{"id":"e96589e0-a703-c453-a26a-1274aa50f422","timestamp":1623400492299}}
image

Steps to reproduce behavior

  1. Open Atlas
  2. Estimation -> Run analysis on DS (The Data source should not contain the concepts )
@DKashenko DKashenko added the bug label Jun 11, 2021
@ssuvorov-fls ssuvorov-fls self-assigned this Jun 11, 2021
ssuvorov-fls added a commit to OHDSI/Atlas that referenced this issue Jun 11, 2021
@ssuvorov-fls
absent concept set exception is handled now (OHDSI/WebAPI#1897)
5a021e5
This was referenced Jun 11, 2021
Merged
Merged
anton-abushkevich pushed a commit to OHDSI/Atlas that referenced this issue Jun 15, 2021
@ssuvorov-fls
absent concept set exception is handled now (OHDSI/WebAPI#1897) (#2557)
391ba2d 
Co-authored-by: Sergey Suvorov <sergey.suvorov@odysseusinc.com>
ssuvorov-fls added a commit to OHDSI/Atlas that referenced this issue Jun 15, 2021
@ssuvorov-fls
absent concept set exception is handled now (OHDSI/WebAPI#1897) (#2557)
a38f7eb 
Co-authored-by: Sergey Suvorov <sergey.suvorov@odysseusinc.com>
(cherry picked from commit 391ba2d)
@anthonysena anthonysena added this to the v2.10.0 milestone Aug 17, 2021
m0nhawk pushed a commit to uc-cdis/Atlas that referenced this issue Nov 1, 2021
@ssuvorov-fls @m0nhawk
absent concept set exception is handled now (OHDSI/WebAPI#1897) (OHDS…
5732b06 
…I#2557)

Co-authored-by: Sergey Suvorov <sergey.suvorov@odysseusinc.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ssuvorov-fls ssuvorov-fls

Labels
bug
Projects
None yet
Milestone
v2.10.0
3 participants
@anthonysena @ssuvorov-fls @DKashenko