Cannot find a concept by its id or code

[ttemnikova]

Expected behavior

The search works both with concept names and ids/codes

Actual behavior

NO RESULTS FOUND FOR "<id/code>"

Steps to reproduce behavior

Login
Go to Search
Look for a concept by its id or code (e.g. 1112807)

[chrisknoll]

There was a recent change where we won't search by concept_id if the input string isn't numeric. Meaning: the WHERE concept_id = 'query' is not performed if the input string isn't numeric.

There may be an issue in the logic where the check is reversed (ie: it won't search for concept_id if it is numeric) but I thought this was tested. Let me confirm.

[anton-abushkevich]

Addition: search by concept ID with Solr woks fine. The problem seems to be only with direct DB search.

[chrisknoll]

Ok, Thanks. Very odd since that was the main way I tested the change :( Let me dig into it.

[chrisknoll]

I found this error in the log:

Caused by: org.postgresql.util.PSQLException: ERROR: operator does not exist: bigint = character varying
  Hint: No operator matches the given name and argument types. You might need to add explicit type casts.

Very strange that I did not see this before when I tested for with/without conceptID query. But I'll apply necessary casts.

[chrisknoll]

Fix Submitted. This was sloppy testing on my part. When I had the original query working, I found that I could make the conceptID optional if the query is numeric. My test was to perform with and without numeric query and observe the query dropped the additional criteria, but I didn't confirm the execution result.