user role mappings are removed when user is removed from group in AD/LDAP #2148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisknoll
requested changes
Dec 13, 2022
| @@ -72,18 +70,18 @@ public RoleEntity addRole(String roleName, boolean isSystem) { | |||
| return role; | |||
| } | |||
|
|
|||
| public String addUserToRole(String roleName, String login) { | |||
| public String addUserToRole(String roleName, String login, UserOrigin userOrigin) { | |||
| Guard.checkNotEmpty(roleName); | |||
There was a problem hiding this comment.
Let's practice backwards compatability: this is a public method which we are changing the functional signature. Let's keep the existing addUserToRole(String roleName, String login) intact, but change the implementation to call the new form with a default value:
public String addUserToRole(String roleName, String login) {
return this.adduserToRole(String roleName, String login, UserOrigin.SYSTEM);
}
There was a problem hiding this comment.
you're right
done
chrisknoll
approved these changes
Dec 14, 2022
delete-merged-branch
bot
deleted the
feature/issue-2146-remove-role-mapping
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1959