Switch isNumeric() to anayisID test when casting. #2209
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2187.
These changes span a large number of files. I did not change any files related to heracles reports (these should probably be deprecated).
The general strategy is moving away from isNumeric() and instead depending on the record's
analysis_id
to determine how the casting should perform. The problem with isNumeric() is that numeric values like '123.45' were passign the isNumeric() test, but can not be casted to an integer. By using analysis_id you can be certain that the cast you are doing is appropriate to the analysis that generated the record.