Finalizing externalizing Vocabulary Search Apache Solr implementation #2308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… Bouncy Castle Crypto, Shiro, Tomcat Embedded, SnakeYAML, org.json:json) - add missing exclusions for json-smart so that the latest version is effective in the result WAR - fixing typos in a few exclusions
Shiro version update (1.10.1)
… API (org.ohdsi:standardized-analysis-specs:1.5.0) Adding webapi-solr profile and referencing a new webapi-solr repository (org.ohdsi:webapi-solr:1.0.0) Finalizing externalizing the Vocabulary Search Apache Solr implementation ===================================== Additionally fixing a failing unit test CohortResultsServiceTest.prepareGetTimeToEventDrilldown
alex-odysseus
requested review from
chrisknoll,
anthonysena and
ssuvorov-fls
alex-odysseus
changed the title
|
The test failure is pre-existing, and is related to a change in the underlying sql, I can post a commit to this branch to fix. |
anthonysena
reviewed
Oct 4, 2023
| @@ -1,6 +1,6 @@ | |||
| package org.ohdsi.webapi.cohortanalysis; | |||
|
|
|||
| import org.ohdsi.webapi.info.ConfigurationInfo; | |||
| import org.ohdsi.info.ConfigurationInfo; | |||
There was a problem hiding this comment.
Noting that this class was moved to the StandardizedAnalysisAPI (v1.5.0) project hence the namespace change.
anthonysena
reviewed
Oct 4, 2023
| import org.ohdsi.circe.vocabulary.ConceptSetExpression; | ||
| import org.ohdsi.webapi.vocabulary.Concept; | ||
| import org.ohdsi.vocabulary.Concept; |
There was a problem hiding this comment.
Noting that this class was moved to the StandardizedAnalysisAPI (v1.5.0) project hence the namespace change.
anthonysena
requested changes
Oct 4, 2023
src/test/resources/cohortresults/sql/cohortSpecific/getTimeToEventDrilldown-expected.sql
Show resolved
Hide resolved
anthonysena
approved these changes
Oct 4, 2023
delete-merged-branch
bot
deleted the
finalizing-externalizing-vocabulary-search-apache-solr-implementation
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Referring common Vocabulary Search classes from Standardized Analysis API (org.ohdsi:standardized-analysis-specs:1.5.0)
Adding webapi-solr profile and referencing a new webapi-solr repository (org.ohdsi:webapi-solr:1.0.0)
Finalizing externalizing the Vocabulary Search Apache Solr implementation
=====================================
Additionally fixing a failing unit test CohortResultsServiceTest.prepareGetTimeToEventDrilldown
Blocked by OHDSI/StandardizedAnalysisAPI#56 and OHDSI/webapi-solr#1
Related to #2196 and #2250