Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Suggested Feature] Indicate which mappings (represented by arrows) have no information #35

Closed
aguynamedryan opened this issue Apr 23, 2015 · 6 comments

Comments

@aguynamedryan
Copy link
Contributor

It would be nice to be able to tell, at a glance, which column mappings have no comments or logic filled out. At the table-level view, a table would be considered “incomplete” if it contains any “incomplete” column mappings. That way, as I’m looking over the entire ETL, I can see what work is still left to be done.

Tentatively we could render just the outline of the arrows in a thick border, leaving the center of the arrow “hollow”. Or we can color the arrows yellow?

@claire-oi
Copy link
Contributor

We've workshopped this feature internally a bit and come up with the following approach:

Instead of showing "incomplete" arrows in a different color or making them "hollow", we will instead simply hide "completed" arrows. A field-level arrow is "complete" if it meets any of the following three criteria :

  • has text in the comment field
  • has text in the logic field
  • has been manually marked "completed"

A table-level arrow is considered complete if it meets either of the two following criteria:

  • has one or more associated field-level arrows and all associated arrows are "complete"
  • has been manually marked "completed"

Users will be able to toggle between showing/hiding completed arrows using a toggle button in a drop down menu.

When the user opt to hid completed arrows, we'll somehow indicate that completed arrows are hidden, either by changing the background color of the mapping panel, or displaying something like "hiding completed" at the top of each mapping panel.

As alluded to above, we'll include a new checkbox in the details panel for each mapping. If a user checks that box, the mapping will be considered complete, even if there is no text in either the logic or comment boxes. We're adding this checkbox to facilitate situations where there might be, say, 43 HCPCS-related fields that all share the same logic and comments when mapped to the procedure_source_value and we only want to fill out the logic and comment section for the first HCPCS -> procedure_source_value field and leave the rest completely empty. We still need to be able to mark the rest of the HCPCS fields as "complete". Since we'll want to quickly mark those 42 other HCPCS codes as completed, we'll provide an option to mark a set of selected arrows as completed/not-completed en-mass using some drop down menu items.

Lastly, when a user hides completed arrows, they might attempt to redraw an arrow that already exists, but has been hidden. Perhaps we need to throw up a warning when the user attempts to redraw an existing arrow and give them the option to turn hiding off.

@schuemie
Copy link
Member

schuemie commented Jun 5, 2015

How about drastically increasing the transparency of completed arrows and make it impossible to select them? So they'd be 'ghosts', reminding people that they're there.

@claire-oi
Copy link
Contributor

@Schumie, we think your suggestion may be a more straight-forward solution. We will test it internally and throw up some screen shots to see if we all like how it turns out.

@aguynamedryan
Copy link
Contributor Author

We're working out a few bugs and still need to implement the "completed" check box, but here's how the UI looks based on @schuemie's suggestions:

hidecompleted

  • Users can toggle "hiding" completed items on and off
  • Completed items are drawn with very high transparency
    • Users can still select completed arrows
  • We added a mint-green color to the selected arrow

@aguynamedryan
Copy link
Contributor Author

@chrisknoll suggested requiring users to manually mark mappings as complete.

This is definitely a far simpler approach and I like it. So now, if a user wants to mark a mapping as complete, they will need to do so by selecting "Mark Highlighted Arrow Complete" from the Arrows menu or using CTRL-D for "Done" ;-) We will no longer adhere to automagically detecting if a mapping is complete as we had proposed above

Since we're having users manually control completion of mappings, I'm also going to be so bold as to remove the option to turn off dimming down the arrows. What I'm saying RiaH will always show "complete" arrows as dim arrows and a user may simply opt to never mark arrows as complete if they want to keep all of the arrows nice and dark.

Simplify, simplify, simplify.

@aguynamedryan
Copy link
Contributor Author

Closed by #85

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants