Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re #2113: disable 2D MPR when datasets have multiple slices for the same ImagePositionPatient #2160

Merged
merged 36 commits into from
Dec 3, 2020

Conversation

Punzo
Copy link
Contributor

@Punzo Punzo commented Nov 6, 2020

Fix for #2113

@Punzo Punzo requested review from fedorov, swederik, JamesAPetts, igoroctaviano and andrebot and removed request for swederik and JamesAPetts November 6, 2020 12:11
@Punzo
Copy link
Contributor Author

Punzo commented Nov 6, 2020

@andrebot @igoroctaviano when you have time could you please review? Thanks

Copy link
Contributor

@igoroctaviano igoroctaviano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 tested locally it its working fine.

@Punzo Punzo removed the request for review from fedorov November 16, 2020 08:15
@codecov
Copy link

codecov bot commented Dec 3, 2020

Codecov Report

Merging #2160 (994685e) into master (4b5a436) will increase coverage by 0.01%.
The diff coverage is 8.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2160      +/-   ##
==========================================
+ Coverage   13.61%   13.63%   +0.01%     
==========================================
  Files         285      284       -1     
  Lines        7389     7388       -1     
  Branches     1395     1395              
==========================================
+ Hits         1006     1007       +1     
+ Misses       5182     5180       -2     
  Partials     1201     1201              
Impacted Files Coverage Δ
platform/core/src/services/UIModalService/index.js 25.00% <ø> (ø)
platform/viewer/src/OHIFStandaloneViewer.js 0.00% <0.00%> (ø)
platform/viewer/src/routes/routesUtil.js 0.00% <0.00%> (ø)
platform/core/src/classes/MetadataProvider.js 4.00% <20.00%> (+0.55%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5210c80...994685e. Read the comment docs.

@Punzo Punzo merged commit b59187c into OHIF:master Dec 3, 2020
haraprasadj added a commit to uc-cdis/Viewers that referenced this pull request Apr 7, 2022
* chore(release): publish [skip ci]

 - @ohif/extension-dicom-tag-browser@0.0.5

* feat: Add error boundary and retry logic for network failures during dynamic imports (OHIF#2145)

Co-authored-by: Davide Punzo <punzodavide@hotmail.it>

* chore(release): publish [skip ci]

 - @ohif/extension-vtk@1.9.0
 - @ohif/ui@1.6.0
 - @ohif/viewer@4.6.0

* feat: add show scroll option to modal

Co-authored-by: Erik Ziegler <erik.sweed@gmail.com>
Co-authored-by: Davide Punzo <punzodavide@hotmail.it>

* chore(release): publish [skip ci]

 - @ohif/extension-dicom-tag-browser@0.1.0
 - @ohif/extension-vtk@1.9.1
 - @ohif/core@2.11.0
 - @ohif/ui@1.7.0
 - @ohif/viewer@4.6.1

* fix: fallback to original dataset VR for XS

Co-authored-by: Davide Punzo <punzodavide@hotmail.it>

* chore(release): publish [skip ci]

 - @ohif/extension-dicom-tag-browser@0.1.1
 - @ohif/extension-vtk@1.9.2
 - @ohif/core@2.11.1
 - @ohif/ui@1.7.1
 - @ohif/viewer@4.6.2

* Re OHIF#2113: disable 2D MPR when datasets have  multiple slices for the same ImagePositionPatient (OHIF#2160)

fix: disable 2D MPR when datasets are 4D

* chore(release): publish [skip ci]

 - @ohif/extension-vtk@1.9.3
 - @ohif/viewer@4.6.3

* feat: Update approach to better handle rtdose instead of disabling panel

Co-authored-by: Davide Punzo <punzodavide@hotmail.it>

* chore(release): publish [skip ci]

 - @ohif/extension-dicom-rt@0.5.0
 - @ohif/viewer@4.7.0

* fix: reset VOI on mpr reset (OHIF#2115)

Co-authored-by: Davide Punzo <punzodavide@hotmail.it>

* chore(release): publish [skip ci]

 - @ohif/extension-vtk@1.9.4
 - @ohif/viewer@4.7.1

* refactor: Update SidePanel.js to use a functional component (OHIF#2179)

* chore(release): publish [skip ci]

 - @ohif/viewer@4.7.2

* Use runtime values for version (OHIF#2204)

* feat: visualize overlapping segments in cornerstone (OHIF#2185)

* feat: visualize overlapping segments

load multiple labelMaps (splitted by dcmjs because overlapping) in a segmentations [IDC2164]

Dynamically update active labelmap [IDC2164]

Co-authored-by: Davide Punzo <punzodavide@hotmail.it>
Co-authored-by: Igor Octaviano <igoroctaviano@gmail.com>

* chore(release): publish [skip ci]

 - @ohif/extension-cornerstone@2.10.0
 - @ohif/extension-dicom-html@1.3.0
 - @ohif/extension-dicom-rt@0.6.0
 - @ohif/extension-dicom-segmentation@0.5.0
 - @ohif/extension-dicom-tag-browser@0.2.0
 - @ohif/extension-vtk@1.10.0
 - @ohif/core@2.12.0
 - @ohif/ui@1.8.0
 - @ohif/viewer@4.8.0

* fix: panel issues and mpr button (IDC2122-IDC2117)

* chore(release): publish [skip ci]

 - @ohif/extension-dicom-rt@0.6.1
 - @ohif/extension-vtk@1.10.1
 - @ohif/viewer@4.8.1

* Add funding acknowledgment of the IDC project

* Add error message on microscopy viewport errors

* Improve/harmonize segmentations panel and add bulk visibility toggles

* Toggle visibility for multiple labelmaps (overlapping)

* Toggle visibility for cornerstone by default

* RTSTRUCT does not apply to the specific image series, the button and the panel should not be shown

* Notify user of buffer errors from vtk / add possibility to add actions to notifications

* Add exit mpr action

* Trigger netlify deploy

* chore(release): publish [skip ci]

 - @ohif/extension-vtk@1.10.2
 - @ohif/core@2.12.1
 - @ohif/ui@1.8.1
 - @ohif/viewer@4.8.2

* chore(release): publish [skip ci]

 - @ohif/extension-dicom-rt@0.6.2
 - @ohif/extension-dicom-segmentation@0.5.1
 - @ohif/viewer@4.8.3

* chore(release): publish [skip ci]

 - @ohif/extension-dicom-microscopy@0.51.4
 - @ohif/viewer@4.8.4

* chore(release): publish [skip ci]

 - @ohif/extension-dicom-rt@0.6.3
 - @ohif/viewer@4.8.5

* fixes OHIF#2249

* chore(release): publish [skip ci]

 - @ohif/viewer@4.8.6

* fix(config): Update Google Healthcare API endpoint from v1beta1 to v1 (OHIF#2256)

* chore(release): publish [skip ci]

 - @ohif/viewer@4.8.7

* Replace instance dropdown to slider for dicom tag browser

* Add error page and not found pages if failed to retrieve study data

* Bump dcmjs

* chore(release): publish [skip ci]

 - @ohif/extension-cornerstone@2.10.1
 - @ohif/extension-dicom-html@1.3.1
 - @ohif/extension-dicom-rt@0.6.4
 - @ohif/extension-dicom-segmentation@0.5.2
 - @ohif/extension-dicom-tag-browser@0.2.1
 - @ohif/extension-vtk@1.10.3
 - @ohif/core@2.12.2
 - @ohif/viewer@4.8.8

* chore(release): publish [skip ci]

 - @ohif/extension-dicom-tag-browser@0.2.2
 - @ohif/extension-vtk@1.10.4
 - @ohif/core@2.12.3
 - @ohif/ui@1.8.2
 - @ohif/viewer@4.8.9

* chore(release): publish [skip ci]

 - @ohif/viewer@4.8.10

* chore: add acknowledgment of IDC (OHIF#2255)

* add acknowldgment of IDC

resolves OHIF#1136

* Fix typo + remove IDC ack example

Co-authored-by: igoroctaviano <igoroctaviano@gmail.com>

* Update dependency: dcmjs@0.18.1

dcmjs
  * @ohif/core: 0.17.2 → 0.18.1
  * @ohif/extension-cornerstone: 0.17.2 → 0.18.1
  * @ohif/extension-dicom-html: 0.17.2 → 0.18.1
  * @ohif/extension-dicom-rt: 0.17.2 → 0.18.1
  * @ohif/extension-dicom-segmentation: 0.17.2 → 0.18.1
  * @ohif/extension-dicom-tag-browser: 0.17.2 → 0.18.1
  * @ohif/extension-vtk: 0.17.2 → 0.18.1
  * @ohif/viewer: 0.17.2 → 0.18.1

* feat(log): add new log service

* chore(release): publish [skip ci]

 - @ohif/extension-cornerstone@2.10.2
 - @ohif/extension-dicom-html@1.3.2
 - @ohif/extension-dicom-rt@0.6.5
 - @ohif/extension-dicom-segmentation@0.5.3
 - @ohif/extension-dicom-tag-browser@0.2.3
 - @ohif/extension-vtk@1.10.5
 - @ohif/core@2.12.4
 - @ohif/viewer@4.8.11

* Update dependency: dcmjs@0.18.2

dcmjs
  * @ohif/core: 0.18.1 → 0.18.2
  * @ohif/extension-cornerstone: 0.18.1 → 0.18.2
  * @ohif/extension-dicom-html: 0.18.1 → 0.18.2
  * @ohif/extension-dicom-rt: 0.18.1 → 0.18.2
  * @ohif/extension-dicom-segmentation: 0.18.1 → 0.18.2
  * @ohif/extension-dicom-tag-browser: 0.18.1 → 0.18.2
  * @ohif/extension-vtk: 0.18.1 → 0.18.2
  * @ohif/viewer: 0.18.1 → 0.18.2

* chore(release): publish [skip ci]

 - @ohif/extension-cornerstone@2.10.3
 - @ohif/extension-dicom-html@1.3.3
 - @ohif/extension-dicom-rt@0.6.6
 - @ohif/extension-dicom-segmentation@0.5.4
 - @ohif/extension-dicom-tag-browser@0.2.4
 - @ohif/extension-vtk@1.10.6
 - @ohif/core@2.12.5
 - @ohif/viewer@4.8.12

* Add onerror event to cover all other unhandled errors

* Update broken test

* Add logger to viewport grid

* chore(release): publish [skip ci]

 - @ohif/extension-debugging@0.2.0
 - @ohif/extension-dicom-microscopy@0.52.0
 - @ohif/extension-dicom-segmentation@0.6.0
 - @ohif/extension-vtk@1.11.0
 - @ohif/core@2.13.0
 - @ohif/ui@1.9.0
 - @ohif/viewer@4.9.0

* Added memoization on VTKMPRToolbarButton component to avoid unnecesary rebuilds (OHIF#2274)

* Added memoization on VTKMPRToolbarButton component to avoid unnecessary rebuilds

* update isDisplaySetReconstructable for float precision

Co-authored-by: Rodrigo Cáceres Vicencio <rcaceres@nursoft.cl>
Co-authored-by: Davide Punzo <punzodavide@hotmail.it>

* chore(release): publish [skip ci]

 - @ohif/extension-vtk@1.11.1
 - @ohif/viewer@4.9.1

* Update dependency: dcmjs@0.18.3 (OHIF#2302)

* chore(release): publish [skip ci]

 - @ohif/extension-cornerstone@2.10.4
 - @ohif/extension-dicom-html@1.3.4
 - @ohif/extension-dicom-rt@0.6.7
 - @ohif/extension-dicom-segmentation@0.6.1
 - @ohif/extension-dicom-tag-browser@0.2.5
 - @ohif/extension-vtk@1.11.2
 - @ohif/core@2.13.1
 - @ohif/viewer@4.9.2

* Update dependency: react-cornerstone-viewport@4.0.5

react-cornerstone-viewport
  * @ohif/extension-cornerstone: 4.0.4 → 4.0.5

* chore(release): publish [skip ci]

 - @ohif/extension-cornerstone@2.10.5
 - @ohif/viewer@4.9.3

* bug(debugger):Fix bug that breaks mailto introduced by logger service

* Force pipeline

* chore(release): publish [skip ci]

 - @ohif/extension-debugging@0.2.1
 - @ohif/viewer@4.9.4

* fix: IDC-2288: Update toolbar tabs after derived displayset loaded (OHIF#2307)

* Update toolbar tabs after derived displayset loaded

* trigger CI

Co-authored-by: Davide Punzo <punzodavide@hotmail.it>

* chore(release): publish [skip ci]

 - @ohif/extension-vtk@1.11.3
 - @ohif/core@2.13.2
 - @ohif/viewer@4.9.5

* IDC 2259: add warning UI for series inconsistencies (OHIF#2331)

IDC 2259: add warning UI for series inconsistencies

remove VTKMPRToolbarButton component memoization (it is not anymore necessary)

* chore(release): publish [skip ci]

 - @ohif/extension-vtk@1.11.4
 - @ohif/core@2.13.3
 - @ohif/ui@1.9.1
 - @ohif/viewer@4.9.6

* Fix scroll speed

* chore(release): publish [skip ci]

 - @ohif/extension-cornerstone@2.10.6
 - @ohif/viewer@4.9.7

* IDC2332 (OHIF#2341)

1) fix the loading of the segmentations when filtering study with ?seriesInstanceUID= syntax
2) add time in the dates of the items of the segmentation combobox list
3) order segmentation combobox list in reverse time order

* chore(release): publish [skip ci]

 - @ohif/extension-dicom-segmentation@0.6.2
 - @ohif/viewer@4.9.8

* fix: Update Dockerfile node version - fix missing dependencies (OHIF#2349)

There were some utilities missing: python, make, g++. Also node version was too old - current node builds without problems.

* IDC2259: do not check uniform spacing in the 4th dimension for 4D datasets (OHIF#2356)

* IDC2346: fix images sorting (OHIF#2358)

* IDC2345: Update dcmjs to version 0.18.4 (OHIF#2362)

* fix(wl): fix metadata provider window level issues after dicomweb update (string vs number)

* Rollback circle ci test

* Comment cache

* chore(release): publish [skip ci]

 - @ohif/extension-cornerstone@2.10.7
 - @ohif/extension-dicom-html@1.3.5
 - @ohif/extension-dicom-rt@0.6.8
 - @ohif/extension-dicom-segmentation@0.6.3
 - @ohif/extension-dicom-tag-browser@0.2.6
 - @ohif/extension-vtk@1.11.5
 - @ohif/core@2.13.4
 - @ohif/viewer@4.9.9

* IDC2345: implement thumbnails footnotes UI for segmentation series inconsistencies warning (OHIF#2364)

* IDC2345: implement thumbnails footnotes UI for segmentation series inconsistencies warning

* chore(release): publish [skip ci]

 - @ohif/extension-dicom-segmentation@0.6.4
 - @ohif/extension-vtk@1.11.6
 - @ohif/core@2.13.5
 - @ohif/viewer@4.9.10

* IDC2361: fix seg combobox filling

* update

* update

* chore(release): publish [skip ci]

 - @ohif/extension-dicom-segmentation@0.6.5
 - @ohif/extension-vtk@1.11.7
 - @ohif/core@2.13.6
 - @ohif/viewer@4.9.11

* IDC-2348: Add acquisition storage sr sopclass to sr html ext (OHIF#2352)

* Add acquisition context storage sr sop to html ext

* chore(release): publish [skip ci]

 - @ohif/extension-dicom-html@1.3.6
 - @ohif/extension-vtk@1.11.8
 - @ohif/core@2.13.7
 - @ohif/viewer@4.9.12

* IDC2345: update dcmjs to version 0.18.5 (OHIF#2378)

* chore(release): publish [skip ci]

 - @ohif/extension-dicom-html@1.3.7
 - @ohif/extension-dicom-rt@0.6.9
 - @ohif/extension-dicom-segmentation@0.6.6
 - @ohif/extension-dicom-tag-browser@0.2.7
 - @ohif/extension-vtk@1.11.9
 - @ohif/core@2.13.8
 - @ohif/viewer@4.9.13

* Remove broken plugin? Seems to have broken child dep

* chore(release): publish [skip ci]

 - @ohif/extension-dicom-html@1.3.8
 - @ohif/extension-dicom-rt@0.6.10
 - @ohif/extension-dicom-segmentation@0.6.7
 - @ohif/extension-dicom-tag-browser@0.2.8
 - @ohif/extension-vtk@1.11.10
 - @ohif/core@2.13.9
 - @ohif/viewer@4.9.14

* remove sitemap dep from older version

* chore(release): publish [skip ci]

 - @ohif/extension-dicom-html@1.3.9
 - @ohif/extension-dicom-rt@0.6.11
 - @ohif/extension-dicom-segmentation@0.6.8
 - @ohif/extension-dicom-tag-browser@0.2.9
 - @ohif/extension-vtk@1.11.11
 - @ohif/core@2.13.10
 - @ohif/viewer@4.9.15

* Implement handlers to retry metadata requests

* Update naming

* Update naming

* Extract hook and add config and documentation

* Improve docs remove env variables

* Add option to disable local storage cache of servers

* Update config property

* chore(release): publish [skip ci]

 - @ohif/viewer@4.9.16

* Re OHIF#2259: UI refinements for warnings (OHIF#2397)

* Re OHIF#2259: highlight series thumbnails border for active series (series in the active viewport)
* Re OHIF#2259: add the warning icon also on the active viewport as an overlay

* chore(release): publish [skip ci]

 - @ohif/extension-cornerstone@2.10.8
 - @ohif/extension-dicom-rt@0.6.12
 - @ohif/extension-dicom-segmentation@0.6.9
 - @ohif/extension-vtk@1.11.12
 - @ohif/core@2.13.11
 - @ohif/ui@1.9.2
 - @ohif/viewer@4.9.17

* fix(dicom-html): Add parsed dicom meta info section (OHIF#2419)

* Add dicom meta info section to dicom sr html
* Update dependency: dcmjs@0.18.8

* chore(release): publish [skip ci]

 - @ohif/extension-cornerstone@2.10.9
 - @ohif/extension-dicom-html@1.3.10
 - @ohif/extension-dicom-rt@0.6.13
 - @ohif/extension-dicom-segmentation@0.6.10
 - @ohif/extension-dicom-tag-browser@0.2.10
 - @ohif/extension-vtk@1.11.13
 - @ohif/core@2.13.12
 - @ohif/viewer@4.9.18

* update dicomweb-client to version 0.8.0

* clean back default config (OHIF#2438)

* chore(release): publish [skip ci]

 - @ohif/viewer@4.9.19

* Add check for metadata

* Remove metadata check

* update dicomweb-client to version 0.8.1

* Resolve opening connection before previsouly setting headers

* Expose retryable option

* chore(release): publish [skip ci]

 - @ohif/extension-debugging@0.2.2
 - @ohif/extension-dicom-tag-browser@0.2.11
 - @ohif/extension-vtk@1.11.14
 - @ohif/core@2.13.13
 - @ohif/viewer@4.9.20

* chore(OHIF#2483) make client-side code debuggable right from the source code (OHIF#2484)

* fix: changed new image handler conditional for 0 edge case (OHIF#2338)

Co-authored-by: Michael Andersen <Michael.Andersen@rmp.uhn.ca>
Co-authored-by: Erik Ziegler <erik.sweed@gmail.com>

* chore(release): publish [skip ci]

 - @ohif/extension-cornerstone@2.10.10
 - @ohif/viewer@4.9.21

* Add badge numbers for seg and rtstruct

* Extract event

* Create CITATION.cff (OHIF#2503)

* Update CITATION.cff (OHIF#2504)

* fix CVE-2019-5021 caused by nginx-apline (OHIF#2514)

Co-authored-by: Matthias Schmieder <matthias.schmieder@stryker.com>

* fix: Remove internet dependency for workbox (addressing OHIF#2109) (OHIF#2151)

* Ignoring *.js.map files as generated in the extensions directories for example

* Fix for OHIF#2109. Removed internet dependency to google workbox

* chore(release): publish [skip ci]

 - @ohif/viewer@4.9.22

* fix: MPR metadata parsing for spacings (OHIF#2517)

* fix: MPR metadata parsing for spacings

* fix: OHIF Metadata provider for validNumbers for imagePlaneModule

* chore(release): publish [skip ci]

 - @ohif/extension-vtk@1.11.15
 - @ohif/core@2.13.14
 - @ohif/viewer@4.9.23

* chore(release): publish [skip ci]

 - @ohif/extension-dicom-rt@0.6.14
 - @ohif/extension-dicom-segmentation@0.6.11
 - @ohif/extension-vtk@1.11.16
 - @ohif/core@2.13.15
 - @ohif/ui@1.9.3
 - @ohif/viewer@4.9.24

* feat: OHIF-1000: Study prefetcher (OHIF#2466)

* Enable study prefetcher and expose configs

* Fix progress for all images

* Enable study loading listener

* Add new default for displaying progress bar for series

* Use events instead of redux to improve performance

* Add documentation, resolve issues with different datasets

* CR Updates

* CR Updates

* CR Updates & Resolve issue when activating both stack and study prefetch

* Add upward and update display set logic

* Add new behavior to prefetching orders

* Rollback display set check and activate cache check

* Remove prefetch check

* Check if displayset has images

* Debounce check cache events

* Remove usued debounce flags

* Ignore prefetching same image

* Use new image instead of image rendered

* Continue prefetch after cache check

* Update prefetch logic after checking cache

* Remove log

* Update displayset count default to 3

* Update netlify config

Co-authored-by: Alireza <ar.sedghi@gmail.com>

* chore(release): publish [skip ci]

 - @ohif/extension-cornerstone@2.11.0
 - @ohif/extension-vtk@1.11.17
 - @ohif/core@2.14.0
 - @ohif/ui@1.10.0
 - @ohif/viewer@4.10.0

* Display warning messages if fails to parse sr report (OHIF#2543)

* chore(release): publish [skip ci]

 - @ohif/extension-vtk@1.11.18
 - @ohif/core@2.14.1
 - @ohif/ui@1.10.1
 - @ohif/viewer@4.10.1

* feat: Update to WADO Image Loader 4.0.3 to add dynamically imported WebAssembly codec support 🚀 (OHIF#2537)

* feat: bump to prerelease of WADO Image Loader for testing

* switch to released versions

* update react-vtkjs-viewport and fix requestpool usage in StudyPrefetcher

* attempt to fix e2e tests for script-tag usage

* fix e2e test error

* switch to using webpack alias in PWA to use dynamic import version of OHIF

* fix copy plugin usage

* try to fix publicpath issue

* bump to 4.0.3

Co-authored-by: Alireza <ar.sedghi@gmail.com>

* chore(release): publish [skip ci]

 - @ohif/extension-cornerstone@2.12.0
 - @ohif/extension-debugging@0.3.0
 - @ohif/extension-dicom-pdf@1.1.0
 - @ohif/extension-dicom-rt@0.7.0
 - @ohif/extension-dicom-segmentation@0.7.0
 - @ohif/extension-vtk@1.12.0
 - @ohif/core@2.15.0
 - @ohif/viewer@4.11.0

* fix: throttle thumbnail progress updates (OHIF#2557)

* chore(release): publish [skip ci]

 - @ohif/extension-vtk@1.12.1
 - @ohif/ui@1.10.2
 - @ohif/viewer@4.11.1

* chore(github): Create config.yml for issues (OHIF#2561)

* chore(github): Create config.yml for issues

* Delete ---support-question.md

* Add FUNDING.yml

* fix regression not showing warnings list on thumbnail for segmentations (OHIF#2563)

* fix regression not showing warnings list on thumbnail for segmentations

* update dcmjs version

* chore(release): publish [skip ci]

 - @ohif/extension-cornerstone@2.12.1
 - @ohif/extension-dicom-html@1.3.11
 - @ohif/extension-dicom-rt@0.7.1
 - @ohif/extension-dicom-segmentation@0.7.1
 - @ohif/extension-dicom-tag-browser@0.2.12
 - @ohif/extension-vtk@1.12.2
 - @ohif/core@2.15.1
 - @ohif/viewer@4.11.2

* Update badge number based on active ds

* feat: Added support for WADO servers built with static hosting (e.g. S3) (OHIF#2566)

* chore(release): publish [skip ci]

 - @ohif/extension-vtk@1.12.3
 - @ohif/core@2.16.0
 - @ohif/viewer@4.12.0

* chore(release): publish [skip ci]

 - @ohif/extension-dicom-rt@0.7.2
 - @ohif/extension-dicom-segmentation@0.7.2
 - @ohif/viewer@4.12.1

* Re OHIF#2571: thumbnail footer remove instance number and add link icon if any derived display set is present (OHIF#2582)

* Re OHIF#2571, thumbnail footer layout modifications: remove instance number and add link icon if any derived display set is present.

* chore(release): publish [skip ci]

 - @ohif/extension-vtk@1.12.4
 - @ohif/ui@1.10.3
 - @ohif/viewer@4.12.2

* fix(OHIF):The header depth was too deep for display SR files. (OHIF#2594)

* chore(release): publish [skip ci]

 - @ohif/extension-dicom-html@1.3.12
 - @ohif/viewer@4.12.3

* Add checks for study metadata in rt and seg panels + bump dcmjs to fix circular references issues naturalizing datasets (OHIF#2588)

Co-authored-by: Davide Punzo <punzodavide@hotmail.it>

* chore(release): publish [skip ci]

 - @ohif/extension-cornerstone@2.12.2
 - @ohif/extension-dicom-html@1.3.13
 - @ohif/extension-dicom-rt@0.7.3
 - @ohif/extension-dicom-segmentation@0.7.3
 - @ohif/extension-dicom-tag-browser@0.2.13
 - @ohif/extension-vtk@1.12.5
 - @ohif/core@2.16.1
 - @ohif/ui@1.10.4
 - @ohif/viewer@4.12.4

* Re OHIF#2590: Fix segments visibility handler

* chore(release): publish [skip ci]

 - @ohif/extension-dicom-segmentation@0.7.4
 - @ohif/viewer@4.12.5

* Re IDC OHIF#2604: show series (with unsupported modalities) on slides panel and on tag explorer (OHIF#2621)

* Re IDC OHIF#2604: show series (with unsupported modalities) on slides panel and on tag explorer

* chore(release): publish [skip ci]

 - @ohif/extension-dicom-tag-browser@0.2.14
 - @ohif/extension-vtk@1.12.6
 - @ohif/core@2.16.2
 - @ohif/ui@1.10.5
 - @ohif/viewer@4.12.6

* Update cornerstone deps (OHIF#2628)

* update cornerstone deps

* chore(release): publish [skip ci]

 - @ohif/extension-cornerstone@2.12.3
 - @ohif/extension-debugging@0.3.1
 - @ohif/extension-dicom-html@1.3.14
 - @ohif/extension-dicom-pdf@1.1.1
 - @ohif/extension-dicom-rt@0.7.4
 - @ohif/extension-dicom-segmentation@0.7.5
 - @ohif/extension-dicom-tag-browser@0.2.15
 - @ohif/extension-vtk@1.12.7
 - @ohif/core@2.16.3
 - @ohif/viewer@4.12.7

* update docker remote version for CI (OHIF#2629)

* IDC Re OHIF#2633: fix slider min and max (OHIF#2634)

* IDC Re OHIF#2633: fix slider min and max

* chore(release): publish [skip ci]

 - @ohif/extension-dicom-tag-browser@0.2.16

* chore: Add research notice (OHIF#2458)

* fix: SeriesTime and SeriesDate are only set for the first series and undefined for the remaining ones (OHIF#2476)

* set SeriesDate and SeriesTime for all series, instead of only for the first series

* set SeriesDate and SeriesTime only when they are undefined

* fix: equality operator

Co-authored-by: Christian El Salloum <christian.elsalloum@emtensor.com>
Co-authored-by: Alireza <ar.sedghi@gmail.com>

* chore(release): publish [skip ci]

 - @ohif/extension-vtk@1.12.8
 - @ohif/core@2.16.4
 - @ohif/viewer@4.12.8

* fix: DICOMFileLoadingListener typo in method name (OHIF#2647)

* chore(release): publish [skip ci]

 - @ohif/extension-vtk@1.12.9
 - @ohif/core@2.16.5
 - @ohif/viewer@4.12.9

* feature: configurable max prefetch request count (OHIF#2632)

* feature: configurable max prefetch request count

* update name and default value for prefetch number

Co-authored-by: Stefan Silviu <silviu.stefan@atta.systems>

* chore(release): publish [skip ci]

 - @ohif/extension-vtk@1.12.10
 - @ohif/core@2.16.6
 - @ohif/viewer@4.12.10

* IDC OHIF#2657: fix rt struct panel update (OHIF#2666)

* Fix observation in RT panel

* chore(release): publish [skip ci]

 - @ohif/extension-dicom-rt@0.7.5
 - @ohif/viewer@4.12.11

* IDC update dcmjs to v0.19.2 (OHIF#2672)

* IDC: update dcmjs with SEG loading regression fix

* chore(release): publish [skip ci]

 - @ohif/extension-cornerstone@2.12.4
 - @ohif/extension-dicom-html@1.3.15
 - @ohif/extension-dicom-rt@0.7.6
 - @ohif/extension-dicom-segmentation@0.7.6
 - @ohif/extension-dicom-tag-browser@0.2.17
 - @ohif/extension-vtk@1.12.11
 - @ohif/core@2.16.7
 - @ohif/viewer@4.12.12

* Feat/v2 e2e static tests (OHIF#2684)

Use the static data for hte e2e tests

* chore(release): publish [skip ci]

 - @ohif/extension-dicom-pdf@1.1.2
 - @ohif/extension-vtk@1.12.12
 - @ohif/core@2.16.8
 - @ohif/viewer@4.12.13

* Fixing broken OpenResty / Orthanc recipes and updating doc (OHIF#2652)

* Updating docker files and documentation for OpenResty / Orthanc recipes.

* fixing link formatting

Co-authored-by: Josiah Vinson <jovinson@microsoft.com>

* chore(release): publish [skip ci]

 - @ohif/viewer@4.12.14

* IDC: update dcmjs to version 0.19.3 (OHIF#2697)

* chore(release): publish [skip ci]

 - @ohif/extension-cornerstone@2.12.5
 - @ohif/extension-dicom-html@1.3.16
 - @ohif/extension-dicom-rt@0.7.7
 - @ohif/extension-dicom-segmentation@0.7.7
 - @ohif/extension-dicom-tag-browser@0.2.18
 - @ohif/extension-vtk@1.12.13
 - @ohif/core@2.16.9
 - @ohif/viewer@4.12.15

* IDC (Re OHIF#1215): Feat/v2 annotations (OHIF#2658)

* Add scoord3d parse / display tool to v2

* Update measurement panel with sr measurements

* Update measurement panel to display read only items

* Cleanup debugger statement

* Check for empty measurement

* fix SCOORD3D coordinates

* Update getRenderableData.js

* fix scoord3d coordinate transformation

* implement logic to detect the ReferencedSOPInstanceUID if missing in the measurement. Fix also world to IJ coordinates.

* Fix broken unit test / import

* fix comment style

* Init tools only once

* restore default config dcmjs server

Co-authored-by: igoroctaviano <igoroctaviano@gmail.com>

* chore(release): publish [skip ci]

 - @ohif/extension-cornerstone@2.12.6
 - @ohif/extension-dicom-html@1.3.17
 - @ohif/extension-vtk@1.12.14
 - @ohif/core@2.16.10
 - @ohif/ui@1.10.6
 - @ohif/viewer@4.12.16

* IDC Re OHIF#2656: update dcmjs 0.19.4 and change tol to 0.01. + fix boundary cases in parseSCOORD3D (OHIF#2699)

* IDC: update dcmjs to version 0.19.4

* IDC Re OHIF#2656: change tol to 0.01 for segs in dcmjs. + fix boundary cases in parseSCOORD3D

* chore(release): publish [skip ci]

 - @ohif/extension-cornerstone@2.12.7
 - @ohif/extension-dicom-html@1.3.18
 - @ohif/extension-dicom-rt@0.7.8
 - @ohif/extension-dicom-segmentation@0.7.8
 - @ohif/extension-dicom-tag-browser@0.2.19
 - @ohif/extension-vtk@1.12.15
 - @ohif/core@2.16.11
 - @ohif/viewer@4.12.17

* refactor: 💡 Bump lodash and immer to avoid vulnerabilities

Bump lodash and immer to avoid vulnerabilities

* chore(release): publish [skip ci]

 - @ohif/extension-vtk@1.12.16
 - @ohif/core@2.16.12
 - @ohif/viewer@4.12.18

* Re IDC OHIF#2698 : fix overflow text  and adding referenced Segs and RTSTRUCT series info in the debug dialog (OHIF#2735)

* chore(release): publish [skip ci]

 - @ohif/extension-debugging@0.3.2
 - @ohif/viewer@4.12.19

* fix: remove docz + node version fix on docker (OHIF#2743)

* fix: docz uses too outdated packages and current documentation hasnt being updated oftenly. removing it

* fix: node docker version to prevent node req "^12.13.0 || ^14.15.0 || >=16" issue

* chore(release): publish [skip ci]

 - @ohif/extension-vtk@1.12.17
 - @ohif/ui@1.10.7
 - @ohif/viewer@4.12.20

* fix: Update fetchPaletteColorLookupTableData: LUT Entries shall be 0 if the table entries value is 2^16 (OHIF#2395)

Opened issue OHIF#2366. 

Following http://dicom.nema.org/medical/Dicom/2018d/output/chtml/part03/sect_C.7.6.3.html#sect_C.7.6.3.1.5, LUT Entries shall be 0 if the table entries value is 2^16.

If numLutEntries is 0, there is no for loop and return empty lut array.

Solution:

const numLutEntries = lutDescriptor[0] ? lutDescriptor[0] : 65536;

This is often used by Philips Ultrasound equipments.

Co-authored-by: Alireza <ar.sedghi@gmail.com>
Co-authored-by: Erik Ziegler <erik.sweed@gmail.com>

* chore(release): publish [skip ci]

 - @ohif/extension-vtk@1.12.18
 - @ohif/core@2.16.13
 - @ohif/viewer@4.12.21

* IDC2733: update dcmjs to version 0.19.7 (OHIF#2745)

* chore(release): publish [skip ci]

 - @ohif/extension-cornerstone@2.12.8
 - @ohif/extension-dicom-html@1.3.19
 - @ohif/extension-dicom-rt@0.7.9
 - @ohif/extension-dicom-segmentation@0.7.9
 - @ohif/extension-dicom-tag-browser@0.2.20
 - @ohif/extension-vtk@1.12.19
 - @ohif/core@2.16.14
 - @ohif/viewer@4.12.22

* Update dependency: dcmjs@0.19.8

dcmjs
  * @ohif/core: 0.19.7 → 0.19.8
  * @ohif/extension-cornerstone: 0.19.7 → 0.19.8
  * @ohif/extension-dicom-html: 0.19.7 → 0.19.8
  * @ohif/extension-dicom-rt: 0.19.7 → 0.19.8
  * @ohif/extension-dicom-segmentation: 0.19.7 → 0.19.8
  * @ohif/extension-dicom-tag-browser: 0.19.7 → 0.19.8
  * @ohif/extension-vtk: 0.19.7 → 0.19.8
  * @ohif/viewer: 0.19.7 → 0.19.8

* chore(release): publish [skip ci]

 - @ohif/extension-cornerstone@2.12.9
 - @ohif/extension-dicom-html@1.3.20
 - @ohif/extension-dicom-rt@0.7.10
 - @ohif/extension-dicom-segmentation@0.7.10
 - @ohif/extension-dicom-tag-browser@0.2.21
 - @ohif/extension-vtk@1.12.20
 - @ohif/core@2.16.15
 - @ohif/viewer@4.12.23

* Re IDC OHIF#2765: fix loading of segmentations at first startup (OHIF#2768)

Re IDC OHIF#2761: fix loading of segmentations

update dcmjs to 0.19.9

* chore(release): publish [skip ci]

 - @ohif/extension-cornerstone@2.12.10
 - @ohif/extension-dicom-html@1.3.21
 - @ohif/extension-dicom-rt@0.7.11
 - @ohif/extension-dicom-segmentation@0.7.11
 - @ohif/extension-dicom-tag-browser@0.2.22
 - @ohif/extension-vtk@1.12.21
 - @ohif/core@2.16.16
 - @ohif/viewer@4.12.24

* Re IDC OHIF#2762: fix thumbnail series type for unsupported SOPClassUID (OHIF#2770)

* Fix thumbnail loading bar (OHIF#2772)

* chore(release): publish [skip ci]

 - @ohif/extension-dicom-tag-browser@0.2.23
 - @ohif/extension-vtk@1.12.22
 - @ohif/core@2.16.17
 - @ohif/ui@1.10.8
 - @ohif/viewer@4.12.25

* update cypress version

Co-authored-by: Davide Punzo <punzodavide@hotmail.it>
Co-authored-by: ohif-bot <danny.ri.brown+ohif-bot@gmail.com>
Co-authored-by: Igor Octaviano <igoroctaviano@gmail.com>
Co-authored-by: Erik Ziegler <erik.sweed@gmail.com>
Co-authored-by: Nikola Mijajlović <nikolamijajlovic1990@gmail.com>
Co-authored-by: Jason Klotzer <jklotzer@google.com>
Co-authored-by: noerog <32459203+noerog@users.noreply.github.com>
Co-authored-by: Andrey Fedorov <andrey.fedorov@gmail.com>
Co-authored-by: Rodrigo Cáceres <walker.without.way@gmail.com>
Co-authored-by: Rodrigo Cáceres Vicencio <rcaceres@nursoft.cl>
Co-authored-by: qqalexqq <qqalexqq@users.noreply.github.com>
Co-authored-by: dannyrb <danny.ri.brown@gmail.com>
Co-authored-by: Woonchan Cho <cronus17@gmail.com>
Co-authored-by: Michael Andersen <32403382+Michael-Andersen@users.noreply.github.com>
Co-authored-by: Michael Andersen <Michael.Andersen@rmp.uhn.ca>
Co-authored-by: Matthias Schmieder <schmieder.matthias@gmail.com>
Co-authored-by: Matthias Schmieder <matthias.schmieder@stryker.com>
Co-authored-by: matthiasg <m.goetzke@curasystems.de>
Co-authored-by: Alireza <ar.sedghi@gmail.com>
Co-authored-by: Bill Wallace <wayfarer3130@gmail.com>
Co-authored-by: Yo Yehudi <yochannah@gmail.com>
Co-authored-by: Christian-e-S <59229557+Christian-e-S@users.noreply.github.com>
Co-authored-by: Christian El Salloum <christian.elsalloum@emtensor.com>
Co-authored-by: Ștefan Silviu-Alexandru <sylviu44@gmail.com>
Co-authored-by: Stefan Silviu <silviu.stefan@atta.systems>
Co-authored-by: Josiah Vinson <88204686+jovinson-ms@users.noreply.github.com>
Co-authored-by: Josiah Vinson <jovinson@microsoft.com>
Co-authored-by: ladeirarodolfo <39910206+ladeirarodolfo@users.noreply.github.com>
Co-authored-by: Tomas Kenda <kenda.tomas@idria.com.ar>
Co-authored-by: haraprasadj <haraprasadj@uchicago.edu>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants