detect/lua/v1: add tests for detect-lua #688
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Task: 4911
jufajardini
requested changes
Jan 28, 2022
Comment on lines
+17
to
+21
| - filter: | ||
| count: 2 | ||
| match: | ||
| event_type: alert | ||
| alert.signature_id: 6677001 |
There was a problem hiding this comment.
Considering there are two other rules added to the test, can you add filters for those as well, or, if they're not needed for the test, considering the original ones in detect-lua, you could probably remove them.
There was a problem hiding this comment.
friendly ping @TheKharleeci
There was a problem hiding this comment.
Thanks for the friendly ping @catenacyber. I think I'm confused on how to go about this particular test
There was a problem hiding this comment.
How can we help ?
What about the comments from Juliana ?
There was a problem hiding this comment.
Currently working on it. Apologies for the late reply
|
Is this still live ? |
yes please |
Closed
|
Followed By: #1086 |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes test for LuaMatchTest01
Link to redmine ticket: https://redmine.openinfosecfoundation.org/issues/4911