eve: revert ethernet addresses when needed #10498
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EVE logging has a direction parameter that can cause the logging of an application layer to be done in a direction that is not linked to the packet. As a result the source IP addres could be assigned the MAC address of the destination IP and reverse. This patch addresses this by propagating the direction to the ethernet logging function and using it there to define the correct mapping. Issue OISF#6405
|
It looks like netflow events need a fix. Setting to draft for now. |
Humm suricata-verify needs an update in fact. |
|
Information: ERROR: QA failed on SURI_TLPW2_autofp_suri_time.
Pipeline 18725 |
| dst = p->ethh->eth_dst; | ||
| } | ||
| break; | ||
| case LOG_DIR_FLOW_TOSERVER: |
There was a problem hiding this comment.
is this the same as LOG_DIR_FLOW?
There was a problem hiding this comment.
Looks like it is and could do with // fallthrough
| @@ -777,8 +813,14 @@ static int CreateJSONEther(JsonBuilder *js, const Packet *p, const Flow *f) | |||
| } | |||
| jb_close(info.dst); | |||
| jb_close(info.src); | |||
| jb_set_object(js, "dest_macs", info.dst); | |||
| jb_set_object(js, "src_macs", info.src); | |||
| /* case is handling netflow too so may need to revert */ | |||
3 tasks
catenacyber
requested changes
Mar 21, 2024
|
Rebased in #11197 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update of #9651 fixing the formatting.
EVE logging has a direction parameter that can cause the logging of an application layer to be done in a direction that is not linked to the packet. As a result the source IP addres could be assigned the MAC address of the destination IP and reverse.
This patch addresses this by propagating the direction to the ethernet logging function and using it there to define the correct mapping.
Issue #6405
Make sure these boxes are signed before submitting your Pull Request -- thank you.
https://docs.suricata.io/en/latest/devguide/contributing/contribution-process.html
https://suricata.io/about/contribution-agreement/ (note: this is only required once)
Link to redmine ticket: https://redmine.openinfosecfoundation.org/issues/6405
Describe changes:
Provide values to any of the below to override the defaults.
SV_BRANCH=OISF/suricata-verify#1667