eve: revert ethernet addresses when needed #9715
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EVE logging has a direction parameter that can cause the logging of an application layer to be done in a direction that is not linked to the packet. As a result the source IP addres could be assigned the MAC address of the destination IP and reverse. This patch addresses this by propagating the direction to the ethernet logging function and using it there to define the correct mapping. Issue OISF#6405
|
Information: QA ran without warnings. Pipeline 16356 |
jasonish
reviewed
Oct 31, 2023
Comment on lines
+780
to
+790
| case LOG_DIR_FLOW_TOSERVER: | ||
| if | ||
| PKT_IS_TOCLIENT(p) | ||
| { | ||
| src = p->ethh->eth_dst; | ||
| dst = p->ethh->eth_src; | ||
| } | ||
| else { | ||
| src = p->ethh->eth_src; | ||
| dst = p->ethh->eth_dst; | ||
| } |
There was a problem hiding this comment.
Weird formatting, but it passes the check. When I run the formatting scripts it reformats it back to something more normal.
There was a problem hiding this comment.
I don't know what happened here. I used regular formatting and it was changed to that by clang.
|
Replaced by #10498 right ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update of #9651
EVE logging has a direction parameter that can cause the logging of an application layer to be done in a direction that is not linked to the packet. As a result the source IP addres could be assigned the MAC address of the destination IP and reverse.
This patch addresses this by propagating the direction to the ethernet logging function and using it there to define the correct mapping.
Issue #6405
Make sure these boxes are signed before submitting your Pull Request -- thank you.
https://docs.suricata.io/en/latest/devguide/codebase/contributing/contribution-process.html
https://suricata.io/about/contribution-agreement/ (note: this is only required once)
Link to redmine ticket: https://redmine.openinfosecfoundation.org/issues/6405
Describe changes:
SV_BRANCH=OISF/suricata-verify#1449