rust/mqtt: create PDU frames prior to input parsing #10834
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PDU frames are now created prior to input parsing to ensure that their creation is independent of the parsing outcome. Additionally, a minor style change has been applied by rustfmt. Ticket OISF#6956
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #10834 +/- ##
==========================================
+ Coverage 82.67% 82.69% +0.01%
==========================================
Files 928 928
Lines 247912 247922 +10
==========================================
+ Hits 204952 205007 +55
+ Misses 42960 42915 -45
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
Do you happen to have a SV test for this? |
No, I don’t. However, there are already tests related to MQTT frames. |
|
I agree one SV test is needed to show the improvement over existing code. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure these boxes are signed before submitting your Pull Request -- thank you.
https://docs.suricata.io/en/latest/devguide/contributing/contribution-process.html
https://suricata.io/about/contribution-agreement/ (note: this is only required once)
Link to redmine ticket:
https://redmine.openinfosecfoundation.org/issues/6956
Describe changes: