Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lua: always available, vendored and sandboxed - v3 #10998

Closed
wants to merge 14 commits into from

Conversation

jasonish
Copy link
Member

Combines the following PRs:

Still a draft, as I think there is still some renaming and clarification in the sandboxing to be resolved.

J0eJ0h and others added 14 commits April 30, 2024 14:56
github-ci: Disable lua on debian 10 as it doesn't have Lua 5.4.

Ticket: OISF#4776
lua 5.4 support is not available in luajit

Ticket: OISF#4776
Ticket: OISF#4776

[Edits by Jason Ish]
- Add Lua in CI where needed
- Disable Lua for builds that don't have Lua 5.4
- rename guards
- SCMalloc to SCCalloc
- remove unused enum
- rename public functions to our naming standard
Remove lua-dev(el) from all CI tests.
The vendored Lua code triggers some scan-build failures, so exclude
the rust/ directory for now. Might want to look at these separately
though.
Remove maintainer-clean-local, this is not needed.

In distclean-local, remove "rust/dist" and "rust/vendor" as they are
created during "make dist".

In "clean-local", remove "rust/target" and "rust/gen" as they are
created during a normal "make".
Modify the CentOS 9 Stream build to not have cbdingen available, as
its already building from the dist.  But add a "make clean" followed
by a "make" to test that it still builds after a clean.
Now that we're fixed to Lua 5.4, the integer size is always 8.
Copy link

NOTE: This PR may contain new authors.

configure.ac Show resolved Hide resolved
Copy link

codecov bot commented Apr 30, 2024

Codecov Report

Attention: Patch coverage is 61.70213% with 54 lines in your changes are missing coverage. Please review.

Project coverage is 81.65%. Comparing base (df8568e) to head (174c6dc).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #10998      +/-   ##
==========================================
- Coverage   83.03%   81.65%   -1.38%     
==========================================
  Files         917      934      +17     
  Lines      248684   256138    +7454     
==========================================
+ Hits       206489   209149    +2660     
- Misses      42195    46989    +4794     
Flag Coverage Δ
fuzzcorpus 61.40% <0.00%> (-2.97%) ⬇️
suricata-verify 61.00% <58.15%> (-1.70%) ⬇️
unittests 61.23% <58.15%> (-1.10%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@suricata-qa
Copy link

Information: QA ran without warnings.

Pipeline 20432

@victorjulien
Copy link
Member

No review yet, but does pass my CI.

@jasonish
Copy link
Member Author

jasonish commented May 1, 2024

No review yet, but does pass my CI.

Cool. Any thoughts on the --disable-lua option?

@jasonish
Copy link
Member Author

Replaced by #11121.

@jasonish jasonish closed this May 22, 2024
@jasonish jasonish deleted the lua-vendored-sandbox/v3 branch May 29, 2024 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
4 participants