lua: always available, vendored and sandboxed - v9 #11121
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-ci: Disable lua on debian 10 as it doesn't have Lua 5.4. Ticket: OISF#4776
lua 5.4 support is not available in luajit Ticket: OISF#4776
Ticket: OISF#4776 [Edits by Jason Ish] - Add Lua in CI where needed - Disable Lua for builds that don't have Lua 5.4
Including: - rename guards - SCMalloc to SCCalloc - remove unused enum - rename public functions to our naming standard
Remove lua-dev(el) from all CI tests.
Now that we're fixed to Lua 5.4, the integer size is always 8.
Its always built-in. However, can be disabled at runtime.
Modify the CentOS 9 Stream build to not have cbdingen available, as its already building from the dist. But add a "make clean" followed by a "make" to test that it still builds after a clean.
The vendored Lua code triggers some scan-build failures, so exclude the rust/ directory for now. Might want to look at these separately though.
Remove maintainer-clean-local, this is not needed. In distclean-local, remove "rust/dist" and "rust/vendor" as they are created during "make dist". In "clean-local", remove "rust/target" and "rust/gen" as they are created during a normal "make".
|
NOTE: This PR may contain new authors. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #11121 +/- ##
==========================================
- Coverage 84.10% 82.74% -1.36%
==========================================
Files 926 942 +16
Lines 250712 258085 +7373
==========================================
+ Hits 210858 213558 +2700
- Misses 39854 44527 +4673
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
qa tokens ran out. ignore the 'pipeline canceled' incoming |
|
ERROR: ERROR: QA failed on build_fetch. Pipeline 20786 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rebase of #10998 with all comments addressed:
Mainly pushing for QA. I have pending: