Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lua: always available, vendored and sandboxed - v9 #11121

Closed
wants to merge 15 commits into from
Closed

lua: always available, vendored and sandboxed - v9 #11121

wants to merge 15 commits into from

Commits on May 22, 2024

  1. lua: require lua 5.4 

    github-ci: Disable lua on debian 10 as it doesn't have Lua 5.4.

Ticket: OISF#4776
    @J0eJ0h @jasonish
    J0eJ0h authored and jasonish committed May 22, 2024
    Configuration menu
    Copy the full SHA
    4090ed6 View commit details
    Browse the repository at this point in the history

  2. lua: Remove luajit support 

    lua 5.4 support is not available in luajit

Ticket: OISF#4776
    @J0eJ0h @jasonish
    J0eJ0h authored and jasonish committed May 22, 2024
    Configuration menu
    Copy the full SHA
    a00c840 View commit details
    Browse the repository at this point in the history

  3. lua: build lua by default 

    Ticket: OISF#4776

[Edits by Jason Ish]
- Add Lua in CI where needed
- Disable Lua for builds that don't have Lua 5.4
    @J0eJ0h @jasonish
    J0eJ0h authored and jasonish committed May 22, 2024
    Configuration menu
    Copy the full SHA
    6c0982a View commit details
    Browse the repository at this point in the history

  4. lua: remove internal references to luajit

    @J0eJ0h @jasonish
    J0eJ0h authored and jasonish committed May 22, 2024
    Configuration menu
    Copy the full SHA
    9673049 View commit details
    Browse the repository at this point in the history

  5. lua: Add lua sandbox for detection rules

    @J0eJ0h @jasonish
    J0eJ0h authored and jasonish committed May 22, 2024
    Configuration menu
    Copy the full SHA
    e493138 View commit details
    Browse the repository at this point in the history

  6. lua: Add config override for lua sandbox limits

    @J0eJ0h @jasonish
    J0eJ0h authored and jasonish committed May 22, 2024
    Configuration menu
    Copy the full SHA
    0c544cd View commit details
    Browse the repository at this point in the history

  7. lua: Add config to allow sandbox bypass

    @J0eJ0h @jasonish
    J0eJ0h authored and jasonish committed May 22, 2024
    Configuration menu
    Copy the full SHA
    7222cd6 View commit details
    Browse the repository at this point in the history

  8. doc: Initial doc for lua sandbox

    @J0eJ0h @jasonish
    J0eJ0h authored and jasonish committed May 22, 2024
    Configuration menu
    Copy the full SHA
    82daeb7 View commit details
    Browse the repository at this point in the history

  9. lua: misc cleanups in sandbox implementation 

    Including:
- rename guards
- SCMalloc to SCCalloc
- remove unused enum
- rename public functions to our naming standard
    @jasonish
    jasonish committed May 22, 2024
    Configuration menu
    Copy the full SHA
    033fe60 View commit details
    Browse the repository at this point in the history

  10. lua: use rust crate to vendor (bundle) lua 

    Remove lua-dev(el) from all CI tests.
    @jasonish
    jasonish committed May 22, 2024
    Configuration menu
    Copy the full SHA
    25a2956 View commit details
    Browse the repository at this point in the history

  11. rust/lua: remove lua_int8 feature 

    Now that we're fixed to Lua 5.4, the integer size is always 8.
    @jasonish
    jasonish committed May 22, 2024
    Configuration menu
    Copy the full SHA
    d756258 View commit details
    Browse the repository at this point in the history

  12. lua: remove lua as a compile time feature 

    Its always built-in. However, can be disabled at runtime.
    @jasonish
    jasonish committed May 22, 2024
    Configuration menu
    Copy the full SHA
    3e95542 View commit details
    Browse the repository at this point in the history

  13. github-ci: test make after clean without cbindgen 

    Modify the CentOS 9 Stream build to not have cbdingen available, as
its already building from the dist.  But add a "make clean" followed
by a "make" to test that it still builds after a clean.
    @jasonish
    jasonish committed May 22, 2024
    Configuration menu
    Copy the full SHA
    e74ea41 View commit details
    Browse the repository at this point in the history

  14. github-ci/scan-build: exclude rust (lua) 

    The vendored Lua code triggers some scan-build failures, so exclude
the rust/ directory for now. Might want to look at these separately
though.
    @jasonish
    jasonish committed May 22, 2024
    Configuration menu
    Copy the full SHA
    4461321 View commit details
    Browse the repository at this point in the history

  15. rust/Makefile: cleanup "clean" targets 

    Remove maintainer-clean-local, this is not needed.

In distclean-local, remove "rust/dist" and "rust/vendor" as they are
created during "make dist".

In "clean-local", remove "rust/target" and "rust/gen" as they are
created during a normal "make".
    @jasonish
    jasonish committed May 22, 2024
    Configuration menu
    Copy the full SHA
    01ce6c1 View commit details
    Browse the repository at this point in the history