Fix builds, to allow C code called from rust only, to prepare for dynamic register keywords 4683 v5.2 #11218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So that there is no need to remove the final binary, to recompile it if there has been changes in the code.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #11218 +/- ##
==========================================
- Coverage 83.02% 82.87% -0.16%
==========================================
Files 942 942
Lines 250606 250606
==========================================
- Hits 208067 207680 -387
- Misses 42539 42926 +387
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
Very confused by the mismatch of PR title and content. Can you make sure they match up? |
victorjulien
changed the title
catenacyber
changed the title
victorjulien
approved these changes
Jun 6, 2024
Merged
|
Merged in #11270, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to redmine ticket:
Preliminary work for https://redmine.openinfosecfoundation.org/issues/4683
Describe changes:
First commits of #11068
#11069 rebased to get attention (and also fixing fuzz base64 target)
cc @lukashino for DPDK