WIP detect: add option to reenable flow actions #11840
Draft
+12
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add an option to allow rules like `pass tls ...` to be considered `app-layer` instead of `pkt`. This will turn the actions into flow actions. Ticket: OISF#7284.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #11840 +/- ##
==========================================
- Coverage 82.60% 82.56% -0.04%
==========================================
Files 912 912
Lines 249351 249359 +8
==========================================
- Hits 205965 205882 -83
- Misses 43386 43477 +91
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
Information: QA ran without warnings. Pipeline 22887 |
inashivb
reviewed
Oct 2, 2024
There was a problem hiding this comment.
We seem to be missing a suricata.yaml.in and perhaps two doc updates, one documenting this change in behavior, another one talking about how to go back to previous behavior w this setting.
Q bc its draft: Could you please tell what are you expecting on this PR?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an option to allow rules like
pass tls ...to be consideredapp-layerinstead ofpkt. This will turn the actions into flow actions.Ticket: #7284.
SV_BRANCH=OISF/suricata-verify#2066