Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

detect/state: fixed offset mask logic : Bug #2214 V1 #2928

Closed

Conversation

qiangbei
Copy link
Contributor

@qiangbei qiangbei commented Oct 8, 2017

Make sure these boxes are signed before submitting your Pull Request -- thank you.

Link to https://redmine.openinfosecfoundation.org/issues/2214 ticket:

Describe changes:

changed 0xef to 0x7f。
The de_state_sig_array value consists of 2 parts :
the first bit to bypass the rule,the other bits to specify an offset 。
so it 0x7f 。

@qiangbei qiangbei requested a review from a team as a code owner October 8, 2017 13:04
@victorjulien
Copy link
Member

Could you email me at victor AT inliniac DOT net? I don't think I have your email address. Thanks!

@victorjulien
Copy link
Member

Copy link
Member

@victorjulien victorjulien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks @qiangbei

@victorjulien victorjulien added this to the 4.0.1 milestone Oct 11, 2017
@victorjulien
Copy link
Member

Will backport to 3.2.4 as well.

@victorjulien victorjulien mentioned this pull request Oct 16, 2017
@victorjulien
Copy link
Member

Merged in #2941, thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants