rust/lua - fix datatype to lua_pushinteger - v3 #4253
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lua 5.1 and 5.3 use a different integer size. Run a test program to set the integer size used in the Rust FFI layer to Rust.
This variable is no longer used. Instead multiple lua pkg-config names are checked.
Remove passing NULL as a format string parameter in test. Convert to FAIL_IF_NULL.
Merged
|
This fails in some cases (strict compile flags, non-bundled htp). Have a fix queued. |
|
I've merged the magic and pc name commits in #4271. Will take the int size fix with some additional fixes a bit later. |
Merged
|
Merged with additional fix in #4273, thanks Jason! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous PR:
#4248
Changes from last PR:
Link to redmine ticket:
https://redmine.openinfosecfoundation.org/issues/2955
PRScript output (if applicable):