Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/lua/v3 #4273

Merged
merged 2 commits into from Oct 4, 2019
Merged

Fix/lua/v3 #4273

merged 2 commits into from Oct 4, 2019

Conversation

victorjulien
Copy link
Member

#4253, made more robust in case of strict CFLAGS and non-bundled htp.

PRScript output (if applicable):

jasonish and others added 2 commits October 4, 2019 12:26
@jasonish @victorjulien
configure: detect lua integer size
f9c9548 
Lua 5.1 and 5.3 use a different integer size. Run a test program
to set the integer size used in the Rust FFI layer to Rust.
@victorjulien
lua: fix lua int size detection
1e50b2e 
Failed to work with non-bundled htp and with some stricter
compile flags.
@victorjulien victorjulien requested review from jasonish and a team as code owners October 4, 2019 10:56
@victorjulien victorjulien merged commit 1e50b2e into OISF:master Oct 4, 2019
@victorjulien victorjulien mentioned this pull request Oct 4, 2019
Closed
@victorjulien victorjulien deleted the fix/lua/v3 branch October 5, 2019 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasonish jasonish Awaiting requested review from jasonish jasonish is a code owner

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
2 participants
@victorjulien @jasonish