Next/41x/20191129/v10 #4414
Merged
Next/41x/20191129/v10 #4414
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ticket OISF#3340. https://redmine.openinfosecfoundation.org/issues/3340 (cherry picked from commit fccbd36)
If a protocol does not support TxDetectFlags, don't try to use them. The consequence of trying to use them was that a TX would never be considered done, and it would never be freed. This would lead to excessive memory use and performance problems due to walking an ever increasing list. (cherry picked from commit ab471c3)
(cherry picked from commit b1beb76)
(cherry picked from commit 20bc08a)
(cherry picked from commit cde49ec)
Define a TxDetectFlag type and macros to generating C bindings for getting and settings the tx detect flags. (cherry picked from commit 8a232be) VJ: std::os::raw::c_void to libc::c_void
Related ticker OISF#3345: https://redmine.openinfosecfoundation.org/issues/3345 (cherry picked from commit fa4b9d3)
(cherry picked from commit 21f014f)
(cherry picked from commit cb62c8d)
(cherry picked from commit 706558d)
Check that both are set or unset. (cherry picked from commit ba3a2c3)
Example of using GitHub actions to perform builds across CentOS, Ubuntu, Debian and the latest Fedora. (cherry picked from commit 3887f8d)
Add method to check if a parser for an app-layer protocol supports tx detect flags. This is a bit of a hack for now as where we need to run this check from we do not have the IP protocol.
When registing a detection engine, check that the app-layer protocol supports tx detect flags. This is a code implementation error that should be resolved during development. VJ: made this a warning as we're updating an older stable branch.
Related commit for 5.0: 1930b1f
jasonish
approved these changes
Dec 3, 2019
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#4413 except the fatal error is a warning now.
PRScript output (if applicable):
Passed.