Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ssh hassh incomplete v3 #5177

Closed
wants to merge 2 commits into from
Closed

Ssh hassh incomplete v3 #5177

wants to merge 2 commits into from

Conversation

catenacyber
Copy link
Contributor

Link to redmine ticket:
https://redmine.openinfosecfoundation.org/issues/3820

Describe changes:

  • Reformats rust code with rustfmt
  • Fixes handling of malicious incomplete kex_init record (using the record side, and not the parsed size)

PRScript output (if applicable):

suricata-verify-pr: 273

Bonus question : Should we enforce rustfmt in new code ?

@catenacyber
ssh: run rustfmt again
99cf2de
@catenacyber
ssh: fixing incomplete kex parsing
638d478 
We use the record length from the ssh record header,
and not the size of the parsed data, as is done in other places.
@catenacyber catenacyber mentioned this pull request Jul 13, 2020
Closed
victorjulien
victorjulien requested changes Jul 14, 2020
View reviewed changes
Copy link
Member

@victorjulien victorjulien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please resubmit w/o the rustfmt commit.

@catenacyber catenacyber mentioned this pull request Jul 20, 2020
Closed
@catenacyber
Copy link
Contributor Author

Please resubmit w/o the rustfmt commit.

Done.
Why not take this commit ?

@catenacyber catenacyber deleted the ssh-hassh-incomplete-v3 branch September 4, 2020 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@victorjulien victorjulien victorjulien requested changes

@jasonish jasonish Awaiting requested review from jasonish

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@catenacyber @victorjulien